From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 30 Mar 2012 12:01:05 +0200 (CEST) Received: from metis.ext.pengutronix.de ([92.198.50.35]:39129 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903609Ab2C3KAy (ORCPT ); Fri, 30 Mar 2012 12:00:54 +0200 Received: from dude.hi.pengutronix.de ([2001:6f8:1178:2:21e:67ff:fe11:9c5c]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1SDYc7-0004Tg-IU; Fri, 30 Mar 2012 11:59:23 +0200 Received: from ukl by dude.hi.pengutronix.de with local (Exim 4.77) (envelope-from ) id 1SDYbk-0004Z4-0y; Fri, 30 Mar 2012 11:59:00 +0200 Date: Fri, 30 Mar 2012 11:59:00 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: linux-kernel@vger.kernel.org, Andrew Morton Cc: Alexey Dobriyan , Anatolij Gustschin , Andreas Koensgen , Andrew Lunn , Andrew Victor , Arnd Bergmann , Barry Song , Benjamin Herrenschmidt , Bryan Huntsman , cbe-oss-dev@lists.ozlabs.org, Christoph Lameter , Daniel Walker , David Brown , David Howells , "David S. Miller" , David Woodhouse , davinci-linux-open-source@linux.davincidsp.com, Eric Miao , Fenghua Yu , Grant Likely , Guenter Roeck , Haojian Zhuang , Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, Jean-Christophe Plagniol-Villard , Jean Delvare , Jean-Paul Roubelat , Joerg Reuter , Josh Boyer , Kevin Hilman , Klaus Kudielka , Kukjin Kim , Kumar Gala , Kyungmin Park , Lennert Buytenhek , Linus Walleij , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-hams@vger.kernel.org, linux-ia64@vger.kernel.org, linux-ide@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@linux-mips.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, lm-sensors@lm-sensors.org, Lucas De Marchi , Matthew Garrett , Matt Porter , Mauro Carvalho Chehab , netdev@vger.kernel.org, Nicolas Ferre , Nicolas Pitre , Paul Mackerras , platform-driver-x86@vger.kernel.org, Ralf Baechle , Randy Dunlap , Russell King , Samuel Ortiz , Sascha Hauer , Sekhar Nori , Shawn Guo , Tejun Heo , Tomasz Stanislawski , Tony Lindgren , Tony Luck , Yoshinori Sato Subject: Re: [PATCH 00/17] mark const init data with __initconst instead of __initdata Message-ID: <20120330095859.GT15647@pengutronix.de> References: <20120329211131.GA31250@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120329211131.GA31250@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:21e:67ff:fe11:9c5c X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mips@linux-mips.org X-archive-position: 32824 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ukl@pengutronix.de Precedence: bulk X-list: linux-mips Return-Path: On Thu, Mar 29, 2012 at 11:11:31PM +0200, Uwe Kleine-König wrote: > Hello, > > this series fixes a common error to use __initdata to mark const > variables. Most of the time this works well enough to go unnoticed > (though I wonder why the linker doesn't warn about that). > Just try adding something like > > int something __initdata; > > to one of the patched files and compile to see the error. > > While touching these annotations I also corrected the position where it > was wrong to go between the variable name and the =. > > Note this series is not compile tested. After a question by Shawn Guo I noticed that my command to do the changes was to lax and changed things that must not be changed (at least not with further care). Affected are lines like: static const char *at91_dt_board_compat[] __initconst = { While at91_dt_board_compat[0] is const, at91_dt_board_compat is not. I will send a fixed series later today. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |