Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Imre Kaloz <kaloz@openwrt.org>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, david.daney@cavium.com
Subject: Re: [PATCH] STAGING: octeon-ethernet: fix build errors by including interrupt.h
Date: Wed, 18 Apr 2012 16:46:57 -0700	[thread overview]
Message-ID: <20120418234657.GA2202@kroah.com> (raw)
In-Reply-To: <1333996155-30523-1-git-send-email-kaloz@openwrt.org>

On Mon, Apr 09, 2012 at 08:29:15PM +0200, Imre Kaloz wrote:
> This patch fixes the following build failures:
> 
> drivers/staging/octeon/ethernet.c: In function 'cvm_oct_cleanup_module':
> drivers/staging/octeon/ethernet.c:799:2: error: implicit declaration of function 'free_irq'
> drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_no_more_work':
> drivers/staging/octeon/ethernet-rx.c:119:3: error: implicit declaration of function 'enable_irq'
> drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_do_interrupt':
> drivers/staging/octeon/ethernet-rx.c:136:2: error: implicit declaration of function 'disable_irq_nosync'
> drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_rx_initialize':
> drivers/staging/octeon/ethernet-rx.c:532:2: error: implicit declaration of function 'request_irq'
> drivers/staging/octeon/ethernet-tx.c: In function 'cvm_oct_tx_initialize':
> drivers/staging/octeon/ethernet-tx.c:712:2: error: implicit declaration of function 'request_irq'
> drivers/staging/octeon/ethernet-tx.c: In function 'cvm_oct_tx_shutdown':
> drivers/staging/octeon/ethernet-tx.c:723:2: error: implicit declaration of function 'free_irq'
> 
> Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
> Acked-by: David Daney <david.daney@cavium.com>

This patch is messed up and does not apply.

And is this needed for 3.4-final?

Please resend it after you fix up your email client.

thanks,

greg k-h

      parent reply	other threads:[~2012-04-18 23:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09 18:29 [PATCH] STAGING: octeon-ethernet: fix build errors by including interrupt.h Imre Kaloz
2012-04-09 21:33 ` David Daney
2012-04-18 23:46 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120418234657.GA2202@kroah.com \
    --to=greg@kroah.com \
    --cc=david.daney@cavium.com \
    --cc=kaloz@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox