From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 18 Jun 2012 16:52:41 +0200 (CEST) Received: from mail.skyhub.de ([78.46.96.112]:53236 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903530Ab2FROwb (ORCPT ); Mon, 18 Jun 2012 16:52:31 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTP id EF3421D996B; Mon, 18 Jun 2012 16:52:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1340031151; bh=4SQ8U94ruvR8F+CcCPi2T3fZBzySKZIfUG7cYQMz/iU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=ZdcjkjXI/vIsO4oPmyAEiwSuwLrvcMGOeHUwHV iVTi0NHtMdA5RokLfjuWku6FR2V1W3yKOLMEm+Ol6fQH6Bf9zCVC16X2P22IiooUmhW 5HiKFHRYcxX7DVShExLsMB6QsdmFTzyaWNR5LBAgRMwyWb52ETwyn8Y454IVLmCu3g= X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (door.skyhub.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fbH8BO4IQNBm; Mon, 18 Jun 2012 16:52:30 +0200 (CEST) Received: from x1.localdomain (unknown [217.9.48.20]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA; Mon, 18 Jun 2012 16:52:30 +0200 (CEST) Received: by x1.localdomain (Postfix, from userid 1000) id 95E4EAA114; Mon, 18 Jun 2012 16:52:31 +0200 (CEST) Date: Mon, 18 Jun 2012 16:52:31 +0200 From: Borislav Petkov To: Huacai Chen Cc: Sergei Shtylyov , Ralf Baechle , linux-mips@linux-mips.org, Fuxin Zhang , Zhangjin Wu , Huacai Chen , Hongliang Tao , Hua Yan , linux-ide@vger.kernel.org Subject: Re: [PATCH 09/14] ata: Use 32bit DMA in AHCI for Loongson 3. Message-ID: <20120618145231.GA4377@x1.osrc.amd.com> References: <1339747801-28691-1-git-send-email-chenhc@lemote.com> <1339747801-28691-10-git-send-email-chenhc@lemote.com> <4FDB08AC.8010208@mvista.com> <20120617120557.GE31534@liondog.tnic> <20120618101030.GA24308@liondog.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-archive-position: 33689 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: bp@alien8.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: On Mon, Jun 18, 2012 at 06:41:58PM +0800, Huacai Chen wrote: > Ohh, this is because Loongson-3 has a hardware bug, when the HT > controller receive a 64-bit DMA address, the high bits is lost. So set > to 32-bit DMA is just a workaround. Ok, this should definitely go into the commit message of your patch then since it explains why you need that flag set. Thanks. -- Regards/Gruss, Boris.