From: Ralf Baechle <ralf@linux-mips.org>
To: Jayachandran C <jchandra@broadcom.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 1/2] MIPS: Netlogic: define cpu_has_fpu macro
Date: Tue, 14 Aug 2012 15:38:58 +0200 [thread overview]
Message-ID: <20120814133858.GA30856@linux-mips.org> (raw)
In-Reply-To: <1344950773-29299-2-git-send-email-jchandra@broadcom.com>
On Tue, Aug 14, 2012 at 06:56:12PM +0530, Jayachandran C wrote:
> The default implementation of 'cpu_has_fpu' macro calls
> smp_processor_id() which causes this warning when preemption is enabled:
>
> [ 4.664000] Algorithmics/MIPS FPU Emulator v1.5
> [ 4.676000] BUG: using smp_processor_id() in preemptible [00000000] code: init/1
> [ 4.700000] caller is fpu_emulator_cop1Handler+0x434/0x27b8
>
> Work around this by defining cpu_has_fpu for XLR and XLP in
> mach-netlogic/cpu-feature-overrides.h
Where is cpu_has_fpu being invoked from? For exactly the scenario you're
running into there is raw_cpu_has_fpu and I wonder if the caller should be
switched to that instead.
Ralf
next prev parent reply other threads:[~2012-08-14 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 13:26 [PATCH 0/2] MIPS: Netlogic: Fixes for 3.6 Jayachandran C
2012-08-14 13:26 ` [PATCH 1/2] MIPS: Netlogic: define cpu_has_fpu macro Jayachandran C
2012-08-14 13:38 ` Ralf Baechle [this message]
2012-08-14 16:03 ` [PATCH] MIPS: Fix for warning from FPU emulation code Jayachandran C
2012-08-15 17:42 ` Ralf Baechle
2012-08-14 13:26 ` [PATCH 2/2] MIPS: Synchronize MIPS count one CPU at a time Jayachandran C
2012-08-15 10:41 ` Ralf Baechle
-- strict thread matches above, loose matches on Subject: below --
2012-08-14 11:30 [PATCH 1/2] MIPS: Netlogic: define cpu_has_fpu macro Jayachandran C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814133858.GA30856@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=jchandra@broadcom.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox