From: Thierry Reding <thierry.reding@avionic-design.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Antony Pavlov <antonynpavlov@gmail.com>,
Maarten ter Huurne <maarten@treewalker.org>
Subject: Re: [PATCH v2 0/3] MIPS: JZ4740: Move PWM driver to PWM framework
Date: Mon, 10 Sep 2012 19:30:56 +0200 [thread overview]
Message-ID: <20120910173056.GA31611@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <504E0542.8020309@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]
On Mon, Sep 10, 2012 at 05:20:34PM +0200, Lars-Peter Clausen wrote:
> On 09/10/2012 02:05 PM, Thierry Reding wrote:
> > Hi,
> >
>
> I think v2 looks, good. Will give it some testing later.
>
> > This small series fixes a build error due to a circular header
> > dependency, exports the timer API so it can be used outside of
> > the arch/mips/jz4740 tree and finally moves and converts the
> > JZ4740 PWM driver to the PWM framework.
> >
> > Note that I don't have any hardware to test this on, so I had to
> > rely on compile tests only. Patches 1 and 2 should probably go
> > through the MIPS tree, while I can take patch 3 through the PWM
> > tree. It touches a couple of files in arch/mips but the changes
> > are unlikely to cause conflicts.
>
> Patch 2 and 3 should probably go through the same tree since patch 3 depends
> on patch 2. I'd like to see them both go through the PWM tree.
That's fine with me. I'll probably need an Acked-by from Ralf just to be
safe.
> Patch 1 should go through the MIPS tree, but I still can't see why the issue
> should occur nor does it happen for anybody else except for you. Instead of
> moving the content over to the public irq.h I'd rather like to see the
> private irq.h being renamed.
If we can solve this some other way I'm all for it. Maybe you can share
the defconfig or .config that you use so I can test under the same
conditions.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-10 17:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 12:05 [PATCH v2 0/3] MIPS: JZ4740: Move PWM driver to PWM framework Thierry Reding
2012-09-10 12:05 ` [PATCH v2 1/3] MIPS: JZ4740: Break circular header dependency Thierry Reding
2012-09-10 12:05 ` [PATCH v2 2/3] MIPS: JZ4740: Export timer API Thierry Reding
2012-09-10 12:05 ` [PATCH v2 3/3] pwm: Add Ingenic JZ4740 support Thierry Reding
2012-09-10 21:51 ` Lars-Peter Clausen
2012-09-11 5:02 ` Thierry Reding
2012-09-11 17:54 ` Lars-Peter Clausen
2012-09-10 15:20 ` [PATCH v2 0/3] MIPS: JZ4740: Move PWM driver to PWM framework Lars-Peter Clausen
2012-09-10 17:30 ` Thierry Reding [this message]
2012-09-11 17:56 ` Lars-Peter Clausen
2012-09-12 15:02 ` Thierry Reding
2012-09-22 7:41 ` Thierry Reding
2012-09-23 13:56 ` Ralf Baechle
2012-09-23 17:12 ` Thierry Reding
2012-09-27 19:48 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910173056.GA31611@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=antonynpavlov@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=maarten@treewalker.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox