From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sat, 15 Sep 2012 00:35:47 +0200 (CEST) Received: from mail-pz0-f49.google.com ([209.85.210.49]:54742 "EHLO mail-pz0-f49.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903400Ab2INWfn (ORCPT ); Sat, 15 Sep 2012 00:35:43 +0200 Received: by dajq27 with SMTP id q27so1422327daj.36 for ; Fri, 14 Sep 2012 15:35:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :x-gm-message-state; bh=QQPqKVcFXiZQc9S7EC9X4a9KvEqgrapKZDAnkrz3wmg=; b=O9fCQhWUrtYZDEoE44sk0kprzB4HWoGHZ51K5R/WGJzprxT7TDlHfaJCfhejLjLqQd 5HIwcILkPLp5CcDqgX61LpXHqz64S/u6NC8PjT3D34z11Mfd3jUJ8zkrIslC939xVGDr uuCoULiRfa+Yhq6jwAawYnDSgzUSshQTPIDek92TSa12zNLxwxku73qlYtjQinYS/7oF 9oAyo8Z9WguGdZQ+ej/j2wO8NNZJ/IFq39hQCCpNjtgSeuCUZBF2NIHI1ibDG+tMLp/n 7uZ2dfwnUmZru1yAHHz70CBibFEIiqB5Sau5JnczQOjmmBEnsEg89wZchEt9X4aBxpRT GHiA== Received: by 10.68.242.164 with SMTP id wr4mr7073308pbc.41.1347662136386; Fri, 14 Sep 2012 15:35:36 -0700 (PDT) Received: from localhost (c-67-168-183-230.hsd1.wa.comcast.net. [67.168.183.230]) by mx.google.com with ESMTPS id ho7sm1707972pbc.3.2012.09.14.15.35.32 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 14 Sep 2012 15:35:35 -0700 (PDT) Date: Fri, 14 Sep 2012 15:35:31 -0700 From: Greg Kroah-Hartman To: Bjorn Helgaas Cc: Thierry Reding , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Tony Luck , Fenghua Yu , Geert Uytterhoeven , Ralf Baechle , Paul Mundt , "David S. Miller" , Chris Metcalf , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Chris Zankel , Greg Ungerer , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 1/2] PCI: Annotate pci_fixup_irqs with __devinit Message-ID: <20120914223531.GA8771@kroah.com> References: <1347655456-2542-1-git-send-email-thierry.reding@avionic-design.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQmrqfD/EuigwgrftzoBa6Tumut7fZw8UJMz8rhk+URe2mpxU3wNyfBlSboNZ8ZVHUxzr7wz X-archive-position: 34508 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: gregkh@linuxfoundation.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: On Fri, Sep 14, 2012 at 02:53:11PM -0600, Bjorn Helgaas wrote: > +cc Greg KH > > On Fri, Sep 14, 2012 at 2:44 PM, Thierry Reding > wrote: > > In order to keep pci_fixup_irqs() around after init (e.g. for hotplug), > > mark it __devinit instead of __init. This requires the same change for > > the implementation of the pcibios_update_irq() function on all > > architectures. > > > > Signed-off-by: Thierry Reding > > --- > > Note: Ideally these annotations should go away completely in order to > > be independent of the HOTPLUG symbol. However, there is work underway > > to get rid of HOTPLUG altogether, so I've kept the __devinit for now. No, just take away the __init marking completly. For 3.7, CONFIG_HOTPLUG will always be enabled, making it be the same thing. That way this saves me the time and energy from deleting the __devinit markings when I get to that point in the patch series :) thanks, greg k-h