Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-mips@linux-mips.org, David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] MIPS: Remove redundant TLB invalidate from pmdp_splitting_flush().
Date: Thu, 18 Oct 2012 13:31:55 +0200	[thread overview]
Message-ID: <20121018113154.GA2321@linux-mips.org> (raw)
In-Reply-To: <1350519620-4582-1-git-send-email-ddaney.cavm@gmail.com>

On Wed, Oct 17, 2012 at 05:20:20PM -0700, David Daney wrote:

> diff --git a/arch/mips/mm/pgtable-64.c b/arch/mips/mm/pgtable-64.c
> index 6c9a477..5408bb5 100644
> --- a/arch/mips/mm/pgtable-64.c
> +++ b/arch/mips/mm/pgtable-64.c
> @@ -71,7 +71,7 @@ void pmdp_splitting_flush(struct vm_area_struct *vma,
>  	if (!pmd_trans_splitting(*pmdp)) {
>  		pmd_t pmd = pmd_mksplitting(*pmdp);
>  		set_pmd_at(vma->vm_mm, address, pmdp, pmd);
> -		flush_tlb_range(vma, address, address + HPAGE_SIZE);
> +		/* TLB already flushed by set_pmd_at() */

Thanks, folded into the THP patch.

  Ralf

      reply	other threads:[~2012-10-18 11:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18  0:20 [PATCH] MIPS: Remove redundant TLB invalidate from pmdp_splitting_flush() David Daney
2012-10-18 11:31 ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121018113154.GA2321@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=david.daney@cavium.com \
    --cc=ddaney.cavm@gmail.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox