Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: "Steven J. Hill" <sjhill@mips.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH v4] OF: MIPS: sead3: Implement OF support.
Date: Fri, 18 Jan 2013 14:24:59 +0100	[thread overview]
Message-ID: <20130118132459.GC19406@linux-mips.org> (raw)
In-Reply-To: <1358444223-17247-1-git-send-email-sjhill@mips.com>

On Thu, Jan 17, 2013 at 11:37:03AM -0600, Steven J. Hill wrote:

> From: "Steven J. Hill" <sjhill@mips.com>
> 
> Activate USE_OF for SEAD-3 platform. Add basic DTS file and convert
> memory detection and reservations to use OF.

Applied with this little patch on top:


 arch/mips/include/asm/mips-boards/generic.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/mips/include/asm/mips-boards/generic.h b/arch/mips/include/asm/mips-boards/generic.h
index c01e286..3fc764a 100644
--- a/arch/mips/include/asm/mips-boards/generic.h
+++ b/arch/mips/include/asm/mips-boards/generic.h
@@ -20,6 +20,7 @@
 #ifndef __ASM_MIPS_BOARDS_GENERIC_H
 #define __ASM_MIPS_BOARDS_GENERIC_H
 
+#include <linux/of_fdt.h>
 #include <asm/addrspace.h>
 #include <asm/byteorder.h>
 #include <asm/mips-boards/bonito64.h>

Otherwise including generic.h might result in an error if <linux/of_fdt.h>
has not been included before.

@@ -87,9 +88,7 @@
 
 extern int mips_revision_sconid;
 
-#ifdef CONFIG_OF
 extern struct boot_param_header __dtb_start;
-#endif

There's no need to wrap this declaration.

  Ralf

      reply	other threads:[~2013-01-18 13:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 17:37 [PATCH v4] OF: MIPS: sead3: Implement OF support Steven J. Hill
2013-01-18 13:24 ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130118132459.GC19406@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-mips@linux-mips.org \
    --cc=sjhill@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox