Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: "Jayachandran C." <jchandra@broadcom.com>
To: "Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH 2/9] MIPS: Netlogic: Remove unused EIMR/EIRR functions
Date: Mon, 25 Mar 2013 12:48:29 +0530	[thread overview]
Message-ID: <20130325071828.GA11783@jayachandranc.netlogicmicro.com> (raw)
In-Reply-To: <514E038D.50108@cogentembedded.com>

On Sat, Mar 23, 2013 at 10:33:33PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 03/23/2013 09:27 PM, Jayachandran C wrote:
> 
> >Remove the definitions of {read,write}_c0_{eirr,eimr}. These functions
> >are now unused after the PIC and IRQ code has been updated to use
> >optimized EIMR/EIRR functions which work on both 32-bit and 64-bit.
> >
> >Signed-off-by: Jayachandran C <jchandra@broadcom.com>
> >---
> >  arch/mips/include/asm/netlogic/mips-extns.h |    7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> >
> >diff --git a/arch/mips/include/asm/netlogic/mips-extns.h b/arch/mips/include/asm/netlogic/mips-extns.h
> >index 69d18a0..f299d31 100644
> >--- a/arch/mips/include/asm/netlogic/mips-extns.h
> >+++ b/arch/mips/include/asm/netlogic/mips-extns.h
> [...]
> >@@ -140,7 +136,6 @@ static inline uint64_t read_c0_eirr_and_eimr(void)
> >  		".set	pop"
> >  		: "=r" (val));
> >  #endif
> >-
> 
>    Unrelated whitespace change.
> 
> >  	return val;
> >  }

While updating that function, I had removed an empty line which was not
really needed. Not sure if it is worth adding a line in commit message for
that.

JC.

  reply	other threads:[~2013-03-25  7:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1364062916.git.jchandra@broadcom.com>
2013-03-23 18:27 ` [PATCH 1/9] MIPS: Netlogic: Optimize and fix write_c0_eimr() Jayachandran C
2013-03-23 18:27 ` [PATCH 2/9] MIPS: Netlogic: Remove unused EIMR/EIRR functions Jayachandran C
2013-03-23 19:33   ` Sergei Shtylyov
2013-03-25  7:18     ` Jayachandran C. [this message]
2013-03-23 18:27 ` [PATCH 3/9] MIPS: Netlogic: print cpumask with cpumask_scnprintf Jayachandran C
2013-03-23 18:27 ` [PATCH 4/9] MIPS: Netlogic: Avoid using fixed PIC IRT index Jayachandran C
2013-03-23 18:27 ` [PATCH 5/9] MIPS: Netlogic: Add 32-bit support for XLP Jayachandran C
2013-03-23 18:27 ` [PATCH 6/9] MIPS: Netlogic: Remove unused code Jayachandran C
2013-03-23 18:27 ` [PATCH 7/9] MIPS: Netlogic: Support for multiple built-in device trees Jayachandran C
2013-03-23 18:28 ` [PATCH 8/9] MIPS: Netlogic: Merge platform usb.h to usb-init.c Jayachandran C
2013-03-23 18:28 ` [PATCH 9/9] MIPS: Netlogic: Fix oprofile compile on XLR uniprocessor Jayachandran C
2013-03-24  8:48   ` John Crispin
2013-03-25  7:51     ` [PATCH 9/9 UPDATED] " Jayachandran C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130325071828.GA11783@jayachandranc.netlogicmicro.com \
    --to=jchandra@broadcom.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox