Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: John Crispin <blogic@openwrt.org>
Cc: linux-mips@linux-mips.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency
Date: Mon, 15 Apr 2013 11:15:27 -0700	[thread overview]
Message-ID: <20130415181527.GA25341@kroah.com> (raw)
In-Reply-To: <1365845973-16164-1-git-send-email-blogic@openwrt.org>

On Sat, Apr 13, 2013 at 11:39:32AM +0200, John Crispin wrote:
> With every Ralink SoC that we add, we would need to extend the dependency. In
> order to make life easier we make the symbol depend on MIPS & RALINK and then
> select it from within arch/mips/ralink/.
> 
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
> 
> These 2 patches in this series should be merged via the mips tree. Patch 1/2
> requires an Ack from the tty maintainer.
> 
>  drivers/tty/serial/8250/Kconfig |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index 80fe91e..24ea3c8 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -295,8 +295,8 @@ config SERIAL_8250_EM
>  	  If unsure, say N.
>  
>  config SERIAL_8250_RT288X
> -	bool "Ralink RT288x/RT305x/RT3662/RT3883 serial port support"
> -	depends on SERIAL_8250 && (SOC_RT288X || SOC_RT305X || SOC_RT3883)
> +	bool
> +	depends on SERIAL_8250 && MIPS && RALINK


This patch doesn't create a select anywhere, so how can a user know what
to do here?

greg k-h

  parent reply	other threads:[~2013-04-15 18:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13  9:39 [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency John Crispin
2013-04-13  9:39 ` [PATCH 2/2] tty: serial: ralink: select SERIAL_8250_RT288X when ralink kernel is built John Crispin
2013-04-15 18:15 ` Greg Kroah-Hartman [this message]
2013-04-16  3:57   ` [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency John Crispin
2013-04-16  4:08     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130415181527.GA25341@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=blogic@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox