From: Gleb Natapov <gleb@redhat.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Sanjay Lal <sanjayl@kymasys.com>,
kvm@vger.kernel.org, linux-mips@linux-mips.org,
mtosatti@redhat.com, ralf@linux-mips.org
Subject: Re: [PATCH 2/2] KVM/MIPS32: Wrap calls to gfn_to_pfn() with srcu_read_lock/unlock()
Date: Wed, 15 May 2013 20:30:39 +0300 [thread overview]
Message-ID: <20130515173039.GC24814@redhat.com> (raw)
In-Reply-To: <5193BDC0.6090103@gmail.com>
On Wed, May 15, 2013 at 09:54:24AM -0700, David Daney wrote:
> On 05/15/2013 08:54 AM, Sanjay Lal wrote:
> >
> >On May 14, 2013, at 2:27 AM, Gleb Natapov wrote:
> >
> >>>
> >>>
> >>>+EXPORT_SYMBOL(min_low_pfn); /* defined by bootmem.c, but not exported by generic code */
> >>>+
> >>What you need this for? It is not used anywhere in this patch and by
> >>mips/kvm code in general.
> >
> >I did some digging around myself, since the linker keeps complaining that it can't find min_low_pfn when compiling the KVM module. It seems that it is indirectly pulled in by the cache management functions.
> >
>
> If it is really needed, then the export should probably be done at
> the site of the min_low_pfn definition, not in some random
> architecture file.
>
Definitely. We cannot snick it here like that. Please drop it from this
patch.
> An alternative is to fix the cache management functions so they
> don't require the export.
>
> David Daney
>
> >
> >Regards
> >Sanjay
> >
> >
> >
> >
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Gleb.
next prev parent reply other threads:[~2013-05-15 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 20:21 [PATCH 0/2] KVM/MIPS32: Fixes for Linux 3.10 Sanjay Lal
2013-05-13 20:21 ` [PATCH 1/2] KVM/MIPS32: Move include/asm/kvm.h => include/uapi/asm/kvm.h since it is a user visible API Sanjay Lal
2013-05-13 20:21 ` [PATCH 2/2] KVM/MIPS32: Wrap calls to gfn_to_pfn() with srcu_read_lock/unlock() Sanjay Lal
2013-05-14 9:27 ` Gleb Natapov
2013-05-15 15:54 ` Sanjay Lal
2013-05-15 16:54 ` David Daney
2013-05-15 17:30 ` Gleb Natapov [this message]
2013-05-15 18:36 ` Sanjay Lal
2013-05-16 5:53 ` Gleb Natapov
2013-05-13 21:07 ` [PATCH 0/2] KVM/MIPS32: Fixes for Linux 3.10 David Daney
2013-05-13 22:36 ` Sanjay Lal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130515173039.GC24814@redhat.com \
--to=gleb@redhat.com \
--cc=ddaney.cavm@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mtosatti@redhat.com \
--cc=ralf@linux-mips.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox