From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Aron Xu <aron@debian.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: N64: Define getdents64
Date: Wed, 22 May 2013 15:41:48 +0200 [thread overview]
Message-ID: <20130522134148.GE10769@linux-mips.org> (raw)
In-Reply-To: <519BC32E.2080405@gmail.com>
On Tue, May 21, 2013 at 11:55:42AM -0700, David Daney wrote:
> On 05/21/2013 07:37 AM, Aron Xu wrote:
> >As a relatively new ABI, N64 only had getdents syscall while other modern
> >architectures have getdents64.
> >
> >This was noticed when Python 3.3 shifted to the latter one for aarch64.
> >
> >Signed-off-by: Aron Xu <aron@debian.org>
>
> This looks correct to me. The getdents64 call returns more
> information than getdents (it adds a field for the file type). So,
> although in n64 the widths of the d_ino and d_off fields are the
> same for getdents64 and getdents, we still need to add this syscall.
>
> Acked-by: David Daney <david.daney@cavium.com>
Yes, the patch is looking good but I was really wondering why the other
ABIs had getdents64 wired up but not the native N64, so I started
digging.
Commit 1a1d77dd589de5a567fa95e36aa6999c704ceca4 [Merge with 2.4.0-test7.]
added N64 getdents(2) to arch/mips64/kernel/scall_64.S as syscall 5213,
then dropped again in 578720675c44e54e8aa7c68f6dce59ed37ce3d3b [Overhaul
of the 64-bit syscall interface. Now heritage free.] for 2.5.18 in 2002.
It took a while to be noticed ;)
Thanks a lot!
Ralf
prev parent reply other threads:[~2013-05-22 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 14:37 [PATCH] MIPS: N64: Define getdents64 Aron Xu
2013-05-21 18:55 ` David Daney
2013-05-22 13:41 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522134148.GE10769@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=aron@debian.org \
--cc=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox