From: Thierry Reding <thierry.reding@avionic-design.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, ac100@lists.launchpad.net,
Alan Stern <stern@rowland.harvard.edu>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
alsa-devel@alsa-project.org, Arnd Bergmann <arnd@arndb.de>,
Barry Song <baohua.song@csr.com>, Ben Dooks <ben-linux@fluff.org>,
cpufreq@vger.kernel.org, Dan Williams <djbw@fb.com>,
David Airlie <airlied@linux.ie>,
David Woodhouse <dwmw2@infradead.org>,
Deepak Saxena <dsaxena@plexity.net>,
devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org,
Eduardo Valentin <eduardo.valentin@ti.com>,
Evgeniy Polyakov <zbr@ioremap.net>, Felipe Balbi <balbi@ti.com>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
Grant Likely <grant.likely@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Inki Dae <inki.dae@samsung.com>, Jaroslav Kysela <perex@perex.cz>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Julian Andres Klode <jak@jak-linux.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-ide@vger.kernel.org, linux-mips@linux-mips.org,
linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
linux-watchdog@vger.kernel.org, Marc Dietrich <marvin24@gmx.de>,
Mark Brown <broonie@kernel.org>, Matt Mackall <mpm@selenic.com>,
netdev@vger.kernel.org, Paul Zimmerman <paulz@synopsys.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Ralf Baechle <ralf@linux-mips.org>,
rtc-linux@googlegroups.com, Russell King <linux@arm.linux.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
spi-devel-general@lists.sourceforge.net,
Stephen Warren <swarren@wwwdotorg.org>,
Takashi Iwai <tiwai@suse.de>, Tejun Heo <tj@kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Tony Prisk <linux@prisktech.co.nz>,
Vinod Koul <vinod.koul@intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Wan ZongShun <mcuos.com@gmail.com>,
Wim Van Sebroeck <wim@iguana.be>, Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH 00/33] devm improvement series, part 1, take 2
Date: Thu, 23 May 2013 22:32:43 +0200 [thread overview]
Message-ID: <20130523203243.GA18069@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <1368702961-4325-1-git-send-email-wsa@the-dreams.de>
[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]
On Thu, May 16, 2013 at 01:15:28PM +0200, Wolfram Sang wrote:
> Lately, I have been experimenting how to improve the devm interface to make
> writing device drivers easier and less error prone while also getting rid of
> its subtle issues. I think it has more potential but still needs work and
> definately conistency, especiall in its usage.
>
> The first thing I come up with is a low hanging fruit regarding
> devm_ioremap_resouce(). This function already checks if the passed resource is
> valid and gives an error message if not. So, we can remove similar checks from
> the drivers and get rid of a bit of code and a number of inconsistent error
> strings.
Sorry for jumping in so late. I generally like the idea. One small
inconvenience is that devm_ioremap_resource() returns -EINVAL if
res == NULL, which means that drivers will now also return -EINVAL
in cases where no resource was returned. Typically drivers handle
this by returning something like -ENODEV, -ENXIO, -ENOENT. Some do
return -EINVAL but perhaps having a separate error code (and maybe
error message as well) for a missing resource would be helpful.
Doing this would be rather easy now that you've paved the way by
making devm_ioremap_resource() usage consistent across drivers.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-05-23 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 11:15 [PATCH 00/33] devm improvement series, part 1, take 2 Wolfram Sang
2013-05-16 11:15 ` [PATCH 31/33] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource Wolfram Sang
2013-05-16 14:42 ` John Crispin
2013-05-16 11:57 ` [PATCH 00/33] devm improvement series, part 1, take 2 Artem Bityutskiy
2013-05-16 12:55 ` Viresh Kumar
2013-05-16 13:11 ` Artem Bityutskiy
2013-05-16 13:17 ` Tomi Valkeinen
2013-05-16 13:17 ` Tomi Valkeinen
2013-05-16 16:13 ` Wolfram Sang
2013-05-16 18:29 ` Stephen Warren
2013-05-23 20:32 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523203243.GA18069@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=FlorianSchandinat@gmx.de \
--cc=a.zummo@towertech.it \
--cc=ac100@lists.launchpad.net \
--cc=airlied@linux.ie \
--cc=alexander.shishkin@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=baohua.song@csr.com \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=cpufreq@vger.kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=djbw@fb.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsaxena@plexity.net \
--cc=dwmw2@infradead.org \
--cc=eduardo.valentin@ti.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=inki.dae@samsung.com \
--cc=jak@jak-linux.org \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@prisktech.co.nz \
--cc=marvin24@gmx.de \
--cc=mcuos.com@gmail.com \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=paulz@synopsys.com \
--cc=perex@perex.cz \
--cc=ralf@linux-mips.org \
--cc=rjw@sisk.pl \
--cc=rtc-linux@googlegroups.com \
--cc=rui.zhang@intel.com \
--cc=sameo@linux.intel.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=stern@rowland.harvard.edu \
--cc=sw0312.kim@samsung.com \
--cc=swarren@wwwdotorg.org \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=torvalds@linux-foundation.org \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=wim@iguana.be \
--cc=wsa@the-dreams.de \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox