From: Ralf Baechle <ralf@linux-mips.org>
To: Kamal Dasu <kdasu.kdev@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Fix get_user_page_fast() for mips with cache alias
Date: Tue, 18 Jun 2013 18:47:44 +0200 [thread overview]
Message-ID: <20130618164744.GA21210@linux-mips.org> (raw)
In-Reply-To: <1371233403-30153-1-git-send-email-kdasu.kdev@gmail.com>
On Fri, Jun 14, 2013 at 02:10:03PM -0400, Kamal Dasu wrote:
> get_user_pages_fast() is missing cache flushes for MIPS platforms
> with cache alias. Filesystem failures observed with DirectIO
> operations due to missing flush_anon_page() that use page coloring
> logic to work with cache aliases. This fix falls through to take
> slow_irqon path that calls get_user_pages() that has required
> logic for platforms where cpu_has_dc_aliases is true.
A bit unsatisfying to always fall back to the slow variant yet I like
the patch because of it's simplicity but I wonder if there's not a
better solution.
Ralf
next prev parent reply other threads:[~2013-06-18 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 18:10 [PATCH] MIPS: Fix get_user_page_fast() for mips with cache alias Kamal Dasu
2013-06-18 16:47 ` Ralf Baechle [this message]
2013-07-19 15:34 ` Kevin Cernekee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618164744.GA21210@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=kdasu.kdev@gmail.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox