From: Ralf Baechle <ralf@linux-mips.org>
To: Tony Wu <tung7970@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Add missing cpu_has_mips_1 guardian
Date: Wed, 26 Jun 2013 16:31:16 +0200 [thread overview]
Message-ID: <20130626143115.GA7171@linux-mips.org> (raw)
In-Reply-To: <20130621110301.GA23195@hades.local>
On Fri, Jun 21, 2013 at 07:03:01PM +0800, Tony Wu wrote:
> arch/mips/include/asm/cpu-features.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/include/asm/cpu-features.h b/arch/mips/include/asm/cpu-features.h
> index e5ec8fc..df5e523 100644
> --- a/arch/mips/include/asm/cpu-features.h
> +++ b/arch/mips/include/asm/cpu-features.h
> @@ -136,7 +136,9 @@
> #endif
> #endif
>
> +#ifndef cpu_has_mips_1
> # define cpu_has_mips_1 (cpu_data[0].isa_level & MIPS_CPU_ISA_I)
> +#endif
cpu_has_mips_1 will always evaluate as MIPS I because later ISA revisions
always contain MIPS I as a subset. So maybe we should rather remove
cpu_has_mips_1 and MIPS_CPU_ISA_I entirely. The sole user of cpu_has_mips_1,
proc.c could easily be cleaned up, the sole test for MIPS_CPU_ISA_I in
traps.c is slightly more work to clean up because it really is a test for
the cp0 architecture.
Ralf
next prev parent reply other threads:[~2013-06-26 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 11:03 [PATCH] MIPS: Add missing cpu_has_mips_1 guardian Tony Wu
2013-06-26 14:31 ` Ralf Baechle [this message]
2013-06-26 15:18 ` Ralf Baechle
2013-06-26 16:07 ` Geert Uytterhoeven
2013-06-26 17:00 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626143115.GA7171@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=tung7970@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox