From: Ralf Baechle <ralf@linux-mips.org>
To: "Steven J. Hill" <Steven.Hill@imgtec.com>
Cc: linux-mips@linux-mips.org,
Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>,
Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH v2] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PHYS_OFFSET"
Date: Wed, 26 Jun 2013 16:52:34 +0200 [thread overview]
Message-ID: <20130626145234.GB7171@linux-mips.org> (raw)
In-Reply-To: <1371742590-10138-1-git-send-email-Steven.Hill@imgtec.com>
On Thu, Jun 20, 2013 at 10:36:30AM -0500, Steven J. Hill wrote:
> From: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
>
> This reverts commit 3f4579252aa166641861a64f1c2883365ca126c2. It is
> invalid because the macros CAC_ADDR and UNCAC_ADDR have a kernel
> virtual address as an argument and also returns a kernel virtual
> address. Using and physical address PHYS_OFFSET is blatantly wrong
> for a macro common to multiple platforms.
While the patch itself is looking sane at a glance, I'm wondering if this
is fixing any actual bug or is just the result of a code review?
Ralf
next prev parent reply other threads:[~2013-06-26 14:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 15:36 [PATCH v2] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PHYS_OFFSET" Steven J. Hill
2013-06-26 14:52 ` Ralf Baechle [this message]
2013-06-26 15:34 ` Steven J. Hill
2013-06-26 15:34 ` Steven J. Hill
2013-06-26 15:43 ` Leonid Yegoshin
2013-06-26 16:23 ` Ralf Baechle
2013-06-26 16:50 ` Leonid Yegoshin
2013-06-26 17:50 ` Ralf Baechle
2013-06-26 19:03 ` Leonid Yegoshin
2013-06-26 21:41 ` Maciej W. Rozycki
2013-06-26 23:47 ` Leonid Yegoshin
2013-07-03 14:01 ` Markos Chandras
2013-07-03 15:56 ` Steven J. Hill
2013-07-03 15:56 ` Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626145234.GB7171@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=Steven.Hill@imgtec.com \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox