From: "Jayachandran C." <jchandra@broadcom.com>
To: "Tony Wu" <tung7970@gmail.com>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/2] MIPS: tlbex: Fix typo in r3000 tlb store handler
Date: Thu, 18 Jul 2013 12:11:07 +0530 [thread overview]
Message-ID: <20130718064106.GA24373@jayachandranc.netlogicmicro.com> (raw)
In-Reply-To: <20130717175840-tung7970@googlemail.com>
On Wed, Jul 17, 2013 at 05:59:47PM +0800, Tony Wu wrote:
> Should test against handle_tlbs_end, not handle_tlbs.
>
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Jayachandran C <jchandra@broadcom.com>
> ---
> arch/mips/mm/tlbex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
> index 9ab0f90..605b6fc 100644
> --- a/arch/mips/mm/tlbex.c
> +++ b/arch/mips/mm/tlbex.c
> @@ -1803,7 +1803,7 @@ static void __cpuinit build_r3000_tlb_store_handler(void)
> uasm_i_j(&p, (unsigned long)tlb_do_page_fault_1 & 0x0fffffff);
> uasm_i_nop(&p);
>
> - if (p >= handle_tlbs)
> + if (p >= handle_tlbs_end)
> panic("TLB store handler fastpath space exceeded");
>
> uasm_resolve_relocs(relocs, labels);
Thanks for fixing this.
Acked-by: Jayachandran C. <jchandra@broadcom.com>
You should add the commit which caused the trouble to the commit message,
like:
commit 6ba045f (MIPS: Move generated code to .text for microMIPS) causes
a panic at boot.
JC.
next prev parent reply other threads:[~2013-07-18 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 9:59 [PATCH 1/2] MIPS: tlbex: Fix typo in r3000 tlb store handler Tony Wu
2013-07-17 10:01 ` [PATCH 2/2] MIPS: tlbex: Guard tlbmiss_handler_setup_pgd Tony Wu
2013-07-18 6:53 ` Jayachandran C.
2013-07-18 6:41 ` Jayachandran C. [this message]
2013-07-18 10:43 ` [PATCH 1/2] MIPS: tlbex: Fix typo in r3000 tlb store handler Tony Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130718064106.GA24373@jayachandranc.netlogicmicro.com \
--to=jchandra@broadcom.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=tung7970@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox