From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-mips@linux-mips.org, David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 2/2] MIPS: Remove unreachable break statements from cp1emu.c
Date: Wed, 21 Aug 2013 18:59:21 +0200 [thread overview]
Message-ID: <20130821165920.GN2163@linux-mips.org> (raw)
In-Reply-To: <1376939435-19761-3-git-send-email-ddaney.cavm@gmail.com>
On Mon, Aug 19, 2013 at 12:10:35PM -0700, David Daney wrote:
> There were many cases of:
>
> return something;
> break;
>
> All those break statements are unreachable and thus redundant.
And are generally making code harder to read.
There seems to be a school of thought which believes that any case
block should end in a break - but those seem to not yet have heared
of Duff's Device or the syntatical candy in C that makes it possible.
Patch queued for 3.12. Thanks,
Ralf
prev parent reply other threads:[~2013-08-21 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 19:10 [PATCH 0/2] MIPS: FPU Emulator fixes David Daney
2013-08-19 19:10 ` [PATCH 1/2] MIPS: Handle OCTEON BBIT instructions in FPU emulator David Daney
2013-08-20 17:21 ` Ralf Baechle
2013-08-19 19:10 ` [PATCH 2/2] MIPS: Remove unreachable break statements from cp1emu.c David Daney
2013-08-19 22:20 ` Aaro Koskinen
2013-08-21 16:59 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821165920.GN2163@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox