From: Ralf Baechle <ralf@linux-mips.org>
To: Markos Chandras <Markos.Chandras@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Fix accessing to per-cpu data when flushing the cache
Date: Tue, 17 Sep 2013 18:02:19 +0200 [thread overview]
Message-ID: <20130917160219.GF22468@linux-mips.org> (raw)
In-Reply-To: <20130917114356.GE22468@linux-mips.org>
On Tue, Sep 17, 2013 at 01:43:56PM +0200, Ralf Baechle wrote:
> > >I'd prefer if we change the caller otherwise depending on the platform
> > >a single cache flush might involve several preempt_disable/-enable
> > >invocations. Something like below.
> > >
> > >And it also keeps the header file more usable outside the core kernel
> > >which Florian's recent zboot a little easier.
> > >
> >
> > Hi Ralf,
> >
> > Changing the caller instead of the function in the header file looks
> > good to me. Thanks for fixing it.
>
> I think in the end the patch below is the better way of fixing it.
No, it's not. Most systems have identical caches for all processors
in a system but there are exceptions, so my first patch is the right
one.
Ralf
prev parent reply other threads:[~2013-09-17 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 9:43 [PATCH] MIPS: Fix accessing to per-cpu data when flushing the cache Markos Chandras
2013-09-17 9:43 ` Markos Chandras
2013-09-17 10:44 ` Ralf Baechle
2013-09-17 10:55 ` Markos Chandras
2013-09-17 10:55 ` Markos Chandras
2013-09-17 11:43 ` Ralf Baechle
2013-09-17 16:02 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917160219.GF22468@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Markos.Chandras@imgtec.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox