From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 18 Sep 2013 13:33:53 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:50474 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6826364Ab3IRLdhKma2K (ORCPT ); Wed, 18 Sep 2013 13:33:37 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.7/8.14.4) with ESMTP id r8IBXYkd026829; Wed, 18 Sep 2013 13:33:34 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.7/8.14.7/Submit) id r8IBXYV1026828; Wed, 18 Sep 2013 13:33:34 +0200 Date: Wed, 18 Sep 2013 13:33:34 +0200 From: Ralf Baechle To: Markos Chandras Cc: linux-mips@linux-mips.org Subject: Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well Message-ID: <20130918113333.GL22468@linux-mips.org> References: <1378460846-961-1-git-send-email-markos.chandras@imgtec.com> <20130918111053.GK22468@linux-mips.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130918111053.GK22468@linux-mips.org> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37849 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Wed, Sep 18, 2013 at 01:10:53PM +0200, Ralf Baechle wrote: > > The CMP code is only designed to work with SMP configurations. > > Fixes multiple build problems on certain randconfigs: > > Applied - but I think the logic here may be backwards from a user's > perspective. Shouldn't a user be asked for SMP first, then for > possible platform suboptions (CMP, VSMP, SMTC) of SMP? Also the "if SMP" in Kconfig config MIPS_CMP bool "MIPS CMP framework support" depends on SYS_SUPPORTS_MIPS_CMP + select SMP select SYNC_R4K select SYS_SUPPORTS_SMP select SYS_SUPPORTS_SCHED_SMT if SMP ^^^^^^ now does look a bit silly, doesn't it? I wonder what the original intention was, possibly CMP support but only a uniprocessor kernel, that is MIPS_CMP=y would enable the GIC only, something like that? Ralf