From: Ralf Baechle <ralf@linux-mips.org>
To: Markos Chandras <markos.chandras@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: pci: pci-bcm1480: Include missing vt.h header
Date: Thu, 19 Sep 2013 13:50:40 +0200 [thread overview]
Message-ID: <20130919115040.GW22468@linux-mips.org> (raw)
In-Reply-To: <1379582872-5482-1-git-send-email-markos.chandras@imgtec.com>
On Thu, Sep 19, 2013 at 10:27:52AM +0100, Markos Chandras wrote:
> It's needed for the MAX_NR_CONSOLES macro.
>
> Fixes the following build problem on a randconfig:
>
> arch/mips/pci/pci-bcm1480.c: In function 'bcm1480_pcibios_init':
> arch/mips/pci/pci-bcm1480.c:261:36: error: 'MAX_NR_CONSOLES'
> undeclared (first use in this function)
> arch/mips/pci/pci-bcm1480.c:261:36: note: each undeclared
> identifier is reported only once for each function it appears in
> make[1]: *** [arch/mips/pci/pci-bcm1480.o] Error 1
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
I'm wondering if this *really* has to live in the PCI code. A VGA in
legacy mode should even work with CONFIG_PCI=n, right?
Anyway, applied. Thanks!
Ralf
prev parent reply other threads:[~2013-09-19 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 9:27 [PATCH] MIPS: pci: pci-bcm1480: Include missing vt.h header Markos Chandras
2013-09-19 9:27 ` Markos Chandras
2013-09-19 11:50 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919115040.GW22468@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox