From: Borislav Petkov <bp@alien8.de>
To: Nick Krause <nickkrause@sympatico.ca>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>,
David Daney <ddaney@caviumnetworks.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org
Subject: Re: Patch[Kernel 3.13.5]
Date: Thu, 6 Mar 2014 11:58:21 +0100 [thread overview]
Message-ID: <20140306105821.GA24636@pd.tnic> (raw)
In-Reply-To: <SNT145-W1141791FC5F60B7E0788170A5880@phx.gbl>
On Thu, Mar 06, 2014 at 04:00:04AM +0000, Nick Krause wrote:
> Here is my first patch, adding a break point to fix bug 60845, case fallout through on switch
> in arch/mips/pci/msi-octeon.c.
>
> --- //home/nick/linux-3.13.5/arch/mips/pci/msi-octeon.c.orig 2014-03-05 22:48:19.084372515 -0500
> +++ //home/nick/linux-3.13.5/arch/mips/pci/msi-octeon.c 2014-03-05 22:48:48.388372344 -0500
> @@ -150,6 +150,7 @@ msi_irq_allocated:
> msg.address_lo =
> ((128ul << 20) + CVMX_PCI_MSI_RCV) & 0xffffffff;
> msg.address_hi = ((128ul << 20) + CVMX_PCI_MSI_RCV)>> 32;
> + break;
> case OCTEON_DMA_BAR_TYPE_BIG:
> /* When using big bar, Bar 0 is based at 0 */
> msg.address_lo = (0 + CVMX_PCI_MSI_RCV) & 0xffffffff;
> Got one error no maintainer otherwise not issues with coding style.
Looks like a real bug you've found, as e8635b484f644 still has the
"break" in there.
However, if you want to learn how to prepare patches properly, take a
look at Documentation/SubmittingPatches.
There it also says how to find out who exactly to send this patch to:
$ ./scripts/get_maintainer.pl -f arch/mips/pci/msi-octeon.c
Ralf Baechle <ralf@linux-mips.org> (supporter:MIPS)
linux-mips@linux-mips.org (open list:MIPS)
I've CCed them.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
parent reply other threads:[~2014-03-06 10:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <SNT145-W1141791FC5F60B7E0788170A5880@phx.gbl>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306105821.GA24636@pd.tnic \
--to=bp@alien8.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=nickkrause@sympatico.ca \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox