From: Ralf Baechle <ralf@linux-mips.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
David Daney <david.daney@cavium.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: OCTEON: fix EARLY_PRINTK_8250 build failure
Date: Thu, 27 Mar 2014 08:40:16 +0100 [thread overview]
Message-ID: <20140327074016.GN17197@linux-mips.org> (raw)
In-Reply-To: <1395777525-28910-1-git-send-email-aaro.koskinen@iki.fi>
On Tue, Mar 25, 2014 at 09:58:45PM +0200, Aaro Koskinen wrote:
> Enabling EARLY_PRINTK_8250 breaks OCTEON builds because of multiple
> prom_putchar() implementations. OCTEON provides its own prom_putchar()
> (also used by the watchdog driver), so we should prevent user from
> selecting EARLY_PRINTK_8250 on OCTEON.
There shouldn't be Octeon-specific code in the 8250-driver, not even
the Kconfig bits. Also other systems - at least Sibyte - affected
by the same issue so I went for a different patch.
Ralf
prev parent reply other threads:[~2014-03-27 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 19:58 [PATCH] MIPS: OCTEON: fix EARLY_PRINTK_8250 build failure Aaro Koskinen
2014-03-27 7:40 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327074016.GN17197@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=aaro.koskinen@iki.fi \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox