From: Ralf Baechle <ralf@linux-mips.org>
To: Alex Smith <alex.smith@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH mips-for-linux-next] MIPS: math-emu: Regression fixes
Date: Fri, 23 May 2014 15:17:21 +0200 [thread overview]
Message-ID: <20140523131721.GE17197@linux-mips.org> (raw)
In-Reply-To: <20140523125842.GC334@linux-mips.org>
On Fri, May 23, 2014 at 02:58:42PM +0200, Ralf Baechle wrote:
> > Fix some errors introduced by commit e2efc0ab3a ("MIPS: math-emu:
> > Remove most ifdefery."), which result in incorrect behaviour of the
> > FPU emulator.
> >
> > Signed-off-by: Alex Smith <alex.smith@imgtec.com>
> > ---
> > Ralf, the above commit in mips-for-linux-next causes a regression
> > which this patch fixes (the regression I was seeing is fixed by the
> > last change, but I also noticed a couple of incorrect ISA level
> > checks which I fixed up as well). Could you squash this into that
> > commit?
Seems your patch was not against e2efc0ab3a but top of tree which
resulted in rejects for the first two segments. Just in case you
want to look over them, the new commit id of e2efc0ab3a is now
08a07904e182895e1205f399465a3d622c0115b8 and the other patch which
was affected is 3f7cac416b5e62d37aa693538729c6c23e9b938b [MIPS: math-emu:
Cleanup coding style.]
Thanks!
Ralf
prev parent reply other threads:[~2014-05-23 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 12:49 [PATCH mips-for-linux-next] MIPS: math-emu: Regression fixes Alex Smith
2014-05-23 12:49 ` Alex Smith
2014-05-23 12:58 ` Ralf Baechle
2014-05-23 13:17 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523131721.GE17197@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=alex.smith@imgtec.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox