From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 01 Aug 2014 18:48:35 +0200 (CEST) Received: from p54BA95AA.dip0.t-ipconnect.de ([84.186.149.170]:34431 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6842510AbaHAQsdfv0Ih (ORCPT ); Fri, 1 Aug 2014 18:48:33 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.7/8.14.4) with ESMTP id s71Gm50o017534; Fri, 1 Aug 2014 18:48:05 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.7/8.14.7/Submit) id s71Gm3fb017533; Fri, 1 Aug 2014 18:48:03 +0200 Date: Fri, 1 Aug 2014 18:48:03 +0200 From: Ralf Baechle To: Huacai Chen Cc: Paul Burton , Chen Jie , Linux MIPS Mailing List , =?utf-8?B?546L6ZSQ?= Subject: Re: [PATCH] Not preempt in CP1 exception handling Message-ID: <20140801164803.GA17520@linux-mips.org> References: <1405047990-12519-1-git-send-email-chenhc@lemote.com> <1405048453-12633-1-git-send-email-chenj@lemote.com> <20140711155631.GE8187@pburton-laptop> <20140712093003.GF8187@pburton-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 41860 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Mon, Jul 14, 2014 at 10:22:47AM +0800, Huacai Chen wrote: > What do you think about? If you also prefer to totally remove the > BUG_ON(), I will send a new patch. I agree, removing the BUG_ON() is the right way. Ralf