From: Ralf Baechle <ralf@linux-mips.org>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: Linux MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH 1/2] MIPS: MSP71xx: remove unused plat_irq_dispatch() argument
Date: Thu, 14 Aug 2014 16:45:35 +0200 [thread overview]
Message-ID: <20140814144535.GG21008@linux-mips.org> (raw)
In-Reply-To: <CAHNKnsQ2DcqG3ABGPj=2bLY74XRxouPkFLqGFbZ9MBnQDPfsVQ@mail.gmail.com>
On Thu, Aug 14, 2014 at 06:39:17PM +0400, Sergey Ryazanov wrote:
> >> Remove unused argument to make the plat_irq_dispatch() function
> >> declaration similar to the realization of other platforms.
> >
> > The issue may be harmless but the regs argument of the false argument
> > isn't even being passed in!
> >
> IMHO, this argument can't cause smth terrible, until nobody tries to
> access it, but I can mistake.
Correct.
In this particular case it appears that the value passed for regs is
whatever value there was in $a0 in the interrupted code. Dereferencing
that kind of value would most likely be lethal and crash the kernel
during bootup.
Ralf
next prev parent reply other threads:[~2014-08-14 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 22:09 [PATCH 0/2] MIPS: add common plat_irq_dispatch declaration Sergey Ryazanov
2014-08-13 22:09 ` [PATCH 1/2] MIPS: MSP71xx: remove unused plat_irq_dispatch() argument Sergey Ryazanov
2014-08-14 12:46 ` Ralf Baechle
2014-08-14 14:39 ` Sergey Ryazanov
2014-08-14 14:45 ` Ralf Baechle [this message]
2014-08-13 22:09 ` [PATCH 2/2] MIPS: add common plat_irq_dispatch declaration Sergey Ryazanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814144535.GG21008@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox