From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Joshua Kinard <kumba@gentoo.org>,
Linux MIPS List <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: IP28: Correct IO_BASE in mach-ip28/spaces.h for proper ioremap
Date: Tue, 19 Aug 2014 12:05:02 +0200 [thread overview]
Message-ID: <20140819100502.GA5321@alpha.franken.de> (raw)
In-Reply-To: <20140819080034.GA11547@linux-mips.org>
On Tue, Aug 19, 2014 at 10:00:34AM +0200, Ralf Baechle wrote:
> On Mon, Aug 18, 2014 at 10:55:02PM -0400, Joshua Kinard wrote:
>
> > --- a/arch/mips/include/asm/mach-ip28/spaces.h
> > +++ b/arch/mips/include/asm/mach-ip28/spaces.h
> > @@ -18,7 +18,7 @@
> > #define PHYS_OFFSET _AC(0x20000000, UL)
> >
> > #define UNCAC_BASE _AC(0xc0000000, UL) /* 0xa0000000 + PHYS_OFFSET */
> > -#define IO_BASE UNCAC_BASE
> > +#define IO_BASE _AC(0x9000000000000000, UL)
> >
> > #include <asm/mach-generic/spaces.h>
>
> I think the real culprit is not the definition of IO_BASE but of
> UNCAC_BASE. 0xc0000000UL is KSEG2 for a 32 bit kernel - but for a 64 bit
> kernel UNCAC_BASE should be defined as _AC(0x9000000000000000, UL).
that was my first thought as well. I just wondered whether it's necessary
to reflect PHY_OFFSET != 0... nevertheless UNCAC_BASE is not usuable
for memory access on IP28 at all. At least not without poking at the
memory controller for slower access cycles, which the current kernel
avoids totaly.
> Which are the defaults in <asm/mach-generic/spaces.h> so just deleting
> both UNCAC_BASE and IO_BASE from mach-ip28/spaces.h should fix things?
I'll give a spin later.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2014-08-19 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 2:55 [PATCH] MIPS: IP28: Correct IO_BASE in mach-ip28/spaces.h for proper ioremap Joshua Kinard
2014-08-19 8:00 ` Ralf Baechle
2014-08-19 8:12 ` Ralf Baechle
2014-08-19 10:05 ` Thomas Bogendoerfer [this message]
2014-08-19 20:01 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819100502.GA5321@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=kumba@gentoo.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox