From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 25 Aug 2014 13:27:57 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:51568 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27006709AbaHYL1zfGNPS (ORCPT ); Mon, 25 Aug 2014 13:27:55 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.8/8.14.8) with ESMTP id s7PBRtkX027628; Mon, 25 Aug 2014 13:27:55 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.8/8.14.8/Submit) id s7PBRsGs027627; Mon, 25 Aug 2014 13:27:54 +0200 Date: Mon, 25 Aug 2014 13:27:54 +0200 From: Ralf Baechle To: Julia Lawall Cc: joe@perches.com, kernel-janitors@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/7] MIPS: BCM63xx: delete double assignment Message-ID: <20140825112754.GE27724@linux-mips.org> References: <1408818808-18850-1-git-send-email-Julia.Lawall@lip6.fr> <1408818808-18850-5-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1408818808-18850-5-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 42216 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Sat, Aug 23, 2014 at 08:33:25PM +0200, Julia Lawall wrote: > Delete successive assignments to the same location. In each case, the > duplicated assignment is modified to be in line with other nearby code. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) Looking good, applied. Thanks, Ralf