From: Ralf Baechle <ralf@linux-mips.org>
To: Markos Chandras <markos.chandras@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Kconfig: Select SMP symbols for CMP
Date: Mon, 25 Aug 2014 18:30:14 +0200 [thread overview]
Message-ID: <20140825163014.GF25892@linux-mips.org> (raw)
In-Reply-To: <1406017774-2187-1-git-send-email-markos.chandras@imgtec.com>
On Tue, Jul 22, 2014 at 09:29:34AM +0100, Markos Chandras wrote:
> CMP is an SMP implementation, and as a result of which, it needs
> to select the SYS_SUPPORTS_SMP and SMP symbols. This fixes the
> following build problem when CMP is enabled but SMP is not.
>
> In file included from arch/mips/kernel/smp-cmp.c:34:0:
> ./arch/mips/include/asm/smp.h:26:0: error: "raw_smp_processor_id" redefined
> [-Werror]
> #define raw_smp_processor_id() (current_thread_info()->cpu)
> [...]
> In file included from arch/mips/kernel/smp-cmp.c:34:0:
> ./arch/mips/include/asm/smp.h:59:20: error: redefinition of
> 'smp_send_reschedule'
> [...]
> ./arch/mips/include/asm/smp.h: In function 'smp_send_reschedule':
> ./arch/mips/include/asm/smp.h:63:8: error: dereferencing pointer to incomplete
> type
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> arch/mips/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 4e238e6e661c..9e3b67c65a32 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2026,7 +2026,9 @@ config MIPS_CMP
> bool "MIPS CMP framework support (DEPRECATED)"
> depends on SYS_SUPPORTS_MIPS_CMP
> select MIPS_GIC_IPI
> + select SMP
> select SYNC_R4K
> + select SYS_SUPPORTS_SMP
It's always a bit inelegant to select a SYMBOL and its prerequisite -
but anyway, applied.
Ralf
prev parent reply other threads:[~2014-08-25 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 8:29 [PATCH] MIPS: Kconfig: Select SMP symbols for CMP Markos Chandras
2014-07-22 8:29 ` Markos Chandras
2014-08-25 16:30 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825163014.GF25892@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox