From: Peter Zijlstra <peterz@infradead.org>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
David Howells <dhowells@redhat.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Hirokazu Takata <takata@linux-m32r.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ralf Baechle <ralf@linux-mips.org>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"maintainer:X86 ARCHITECTURE..." <x86@kernel.org>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Chen Gang <gang.chen@asianux.com>,
Victor Kamensky <victor.kamensky@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"Maciej W. Rozycki" <macro@codesourcery.com>,
Sam Ravnborg <sam@ravnborg.org>,
"open list:ALPHA PORT" <linux-alpha@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
"open list:CRIS PORT" <linux-cris-kernel@axis.com>,
"open list:IA64 (Itanium) PL..." <linux-ia64@vger.kernel.org>,
"moderated list:M32R ARCHITECTURE" <linux-m32r@ml.linux-m32r.org>,
"open list:M32R ARCHITECTURE" <linux-m32r-ja@ml.linux-m32r.org>,
"open list:M68K ARCHITECTURE" <linux-m68k@lists.linux-m68k.org>,
"open list:MIPS" <linux-mips@linux-mips.org>,
"open list:PARISC ARCHITECTURE" <linux-parisc@vger.kernel.org>,
"open list:SUPERH" <linux-sh@vger.kernel.org>,
"open list:SPARC + UltraSPAR..." <sparclinux@vger.kernel.org>,
"open list:TENSILICA XTENSA..." <linux-xtensa@linux-xtensa.org>,
"open list:GENERIC INCLUDE/A..." <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
Date: Tue, 23 Sep 2014 17:15:09 +0200 [thread overview]
Message-ID: <20140923151509.GI3312@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1411482607-20948-1-git-send-email-bobby.prani@gmail.com>
On Tue, Sep 23, 2014 at 10:29:50AM -0400, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Looks good to me; I can route it through the locking tree if there's no
objections.
next prev parent reply other threads:[~2014-09-23 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 14:29 [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile Pranith Kumar
2014-09-23 14:29 ` Pranith Kumar
2014-09-23 15:15 ` Peter Zijlstra [this message]
2014-09-23 15:40 ` Jesper Nilsson
2014-09-23 19:43 ` Hans-Christian Egtvedt
2014-09-23 23:56 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923151509.GI3312@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bobby.prani@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=egtvedt@samfundet.no \
--cc=fenghua.yu@intel.com \
--cc=gang.chen@asianux.com \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=hskinnemoen@gmail.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jcmvbkbc@gmail.com \
--cc=jejb@parisc-linux.org \
--cc=jesper.nilsson@axis.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r-ja@ml.linux-m32r.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@arm.linux.org.uk \
--cc=macro@codesourcery.com \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=victor.kamensky@linaro.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox