From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 07 Oct 2014 17:57:29 +0200 (CEST) Received: from mail-pa0-f48.google.com ([209.85.220.48]:45127 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010722AbaJGP510SCKb (ORCPT ); Tue, 7 Oct 2014 17:57:27 +0200 Received: by mail-pa0-f48.google.com with SMTP id eu11so7353055pac.35 for ; Tue, 07 Oct 2014 08:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Xr0U305NZNu1jEhASBP2S+O75TsoF7hcm4FYGKl/giU=; b=hitoM7CVjev8yr/7o/xzVIZsAmrO9Cupb5Uon4BVV0IP5La7ORP6cGJ4GfyWxETgXP rixGA94/IuOn7Uk5st93kVyNPfR3r2MEE4Oy7MaX4qWbeXRIWrQq2KdZksNtfGJ0PnAb 7Ys6N2i1LOSu04cHtYtI28i82Zxj2Nj6K+je/o8OoOdMW6WcksETQXpNoBKxRbLtAE2l LM/HzQx8yABTS2zw2egXqyisjXfzcqDRjZCIIFUO49H/7mkPzDPwqYTYk+uTT8FTS09z rayQaL0JdSGw5CpFS8JIxn7LLEbd55fX7aglX3Y9kaQ36XBtx4zZVTFiV5ZQQwzG54Bx feIQ== X-Received: by 10.68.65.74 with SMTP id v10mr4455613pbs.72.1412697441188; Tue, 07 Oct 2014 08:57:21 -0700 (PDT) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by mx.google.com with ESMTPSA id qj2sm16289341pbc.78.2014.10.07.08.57.20 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 07 Oct 2014 08:57:20 -0700 (PDT) Date: Tue, 7 Oct 2014 08:57:13 -0700 From: Guenter Roeck To: Mark Rutland Cc: "linux-kernel@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , "devel@driverdev.osuosl.org" , "devicetree@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-acpi@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-cris-kernel@axis.com" , "linux-efi@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m32r-ja@ml.linux-m32r.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , "openipmi-developer@lists.sourceforge.net" , "user-mode-linux-devel@lists.sourceforge.net" , "linux-arm-kernel@lists.infradead.org" , "linux-c6x-dev@linux-c6x.org" , "linux-ia64@vger.kernel.org" , "linux-m68k@vger.kernel.org" , "linux-metag@vger.kernel.org" , "linux-mips@linux-mips.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-sh@vger.kernel.org" , "xen-devel@lists.xenproject.org" , Rob Herring , Pawel Moll Subject: Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings Message-ID: <20141007155713.GB28835@roeck-us.net> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-8-git-send-email-linux@roeck-us.net> <20141007110219.GE24725@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141007110219.GE24725@leverpostej> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 43060 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: linux@roeck-us.net Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, Oct 07, 2014 at 12:02:19PM +0100, Mark Rutland wrote: > On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > > Replace reference to pm_power_off (which is an implementation detail) > > and replace it with a more generic description of the driver's functionality. > > > > Cc: Rob Herring > > Cc: Pawel Moll > > Cc: Mark Rutland > > Signed-off-by: Guenter Roeck > > --- > > Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > > index af25e77..1e2260a 100644 > > --- a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > > +++ b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > > @@ -3,8 +3,8 @@ > > QNAP NAS devices have a microcontroller controlling the main power > > supply. This microcontroller is connected to UART1 of the Kirkwood and > > Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the > > -microcontroller to turn the power off. This driver adds a handler to > > -pm_power_off which is called to turn the power off. > > +microcontroller to turn the power off. This driver installs a handler > > +to power off the system. > > I'd remove the last sentence -- the driver is also independent of the > HW, and the description of how the power off works at the HW level is > sufficient. > Done. > With that: > > Acked-by: Mark Rutland > Thanks! Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-f48.google.com ([209.85.220.48]:45127 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010722AbaJGP510SCKb (ORCPT ); Tue, 7 Oct 2014 17:57:27 +0200 Received: by mail-pa0-f48.google.com with SMTP id eu11so7353055pac.35 for ; Tue, 07 Oct 2014 08:57:21 -0700 (PDT) Date: Tue, 7 Oct 2014 08:57:13 -0700 From: Guenter Roeck Subject: Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings Message-ID: <20141007155713.GB28835@roeck-us.net> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-8-git-send-email-linux@roeck-us.net> <20141007110219.GE24725@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141007110219.GE24725@leverpostej> Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Mark Rutland Cc: "linux-kernel@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , "devel@driverdev.osuosl.org" , "devicetree@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-acpi@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-cris-kernel@axis.com" , "linux-efi@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m32r-ja@ml.linux-m32r.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , "openipmi-developer@lists.sourceforge.net" , "user-mode-linux-devel@lists.sourceforge.net" , "linux-arm-kernel@lists.infradead.org" , "linux-c6x-dev@linux-c6x.org" , "linux-ia64@vger.kernel.org" , "linux-m68k@vger.kernel.org" , "linux-metag@vger.kernel.org" , "linux-mips@linux-mips.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-sh@vger.kernel.org" , "xen-devel@lists.xenproject.org" , Rob Herring , Pawel Moll Message-ID: <20141007155713.i_tZVD2EEh118PsCxw2YzFKdpwzqkEsTn4QW3h72a3E@z> On Tue, Oct 07, 2014 at 12:02:19PM +0100, Mark Rutland wrote: > On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > > Replace reference to pm_power_off (which is an implementation detail) > > and replace it with a more generic description of the driver's functionality. > > > > Cc: Rob Herring > > Cc: Pawel Moll > > Cc: Mark Rutland > > Signed-off-by: Guenter Roeck > > --- > > Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > > index af25e77..1e2260a 100644 > > --- a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > > +++ b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > > @@ -3,8 +3,8 @@ > > QNAP NAS devices have a microcontroller controlling the main power > > supply. This microcontroller is connected to UART1 of the Kirkwood and > > Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the > > -microcontroller to turn the power off. This driver adds a handler to > > -pm_power_off which is called to turn the power off. > > +microcontroller to turn the power off. This driver installs a handler > > +to power off the system. > > I'd remove the last sentence -- the driver is also independent of the > HW, and the description of how the power off works at the HW level is > sufficient. > Done. > With that: > > Acked-by: Mark Rutland > Thanks! Guenter