From: Ralf Baechle <ralf@linux-mips.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-mips@linux-mips.org, Huacai Chen <chenhc@lemote.com>,
Markos Chandras <Markos.Chandras@imgtec.com>
Subject: Re: Lemote 2F build failure
Date: Wed, 19 Nov 2014 23:07:06 +0100 [thread overview]
Message-ID: <20141119220706.GB16990@linux-mips.org> (raw)
In-Reply-To: <20141119205405.GA6796@fuloong-minipc.musicnaut.iki.fi>
On Wed, Nov 19, 2014 at 10:54:05PM +0200, Aaro Koskinen wrote:
> On Wed, Nov 19, 2014 at 03:47:18PM +0100, Ralf Baechle wrote:
> > Since I while already I'm getting this failure:
> >
> > ERROR: "loongson_sysconf" [arch/mips/loongson/common/serial.ko] undefined!
> > scripts/Makefile.modpost:90: recipe for target '__modpost' failed
> > make[1]: *** [__modpost] Error 1
> > Makefile:1097: recipe for target 'modules' failed
> > make: *** [modules] Error 2
> >
> >
> > Below a config file to trigger the issue.
>
> Are you sure you posted the right config? The modular serial 8250 build
> works fine for me for 2F, and also your config works.
Quite certainly - the buildbot sends me the error messages followed by the
config file used (which is not one of the defconfig but tweaked in weird
ways) in a single mail.
This issue is popping up for a number of days already for the upstream-sfr
tree's mips-for-linux-next branch; I last saw it for commit
298395f5f43d1ea4b00e8c9ddaa01d9d8e653582 which is still the current HEAD
of that tree.
I don't see an EXPORT_SYMBOL for loongson_sysconf in that tree.
I took a quick look at arch/mips/loongson/common/serial.c. This file
probably shouldn't register a platform device - that's dangerous business
from a module. And it indeed looks like it had never been thought through
what will happen if this file was a module. Just build it always.
Ralf
prev parent reply other threads:[~2014-11-19 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 14:47 Lemote 2F build failure Ralf Baechle
2014-11-19 20:54 ` Aaro Koskinen
2014-11-19 22:07 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119220706.GB16990@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Markos.Chandras@imgtec.com \
--cc=aaro.koskinen@iki.fi \
--cc=chenhc@lemote.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox