From: Ralf Baechle <ralf@linux-mips.org>
To: Daniel Sanders <Daniel.Sanders@imgtec.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
Paul Burton <Paul.Burton@imgtec.com>,
Markos Chandras <Markos.Chandras@imgtec.com>,
James Hogan <James.Hogan@imgtec.com>,
Behan Webster <behanw@converseincode.com>
Subject: Re: [PATCH] MIPS: Changed current_thread_info() to an equivalent supported by both clang and GCC
Date: Fri, 16 Jan 2015 15:37:25 +0100 [thread overview]
Message-ID: <20150116143725.GB22296@linux-mips.org> (raw)
In-Reply-To: <E484D272A3A61B4880CDF2E712E9279F458E8336@hhmail02.hh.imgtec.org>
On Sat, Jan 10, 2015 at 12:53:22PM +0000, Daniel Sanders wrote:
> The main reason I renamed it is that identifiers starting with '__' are reserved. It's pretty unlikely but it's possible that the name will conflict with a C implementation in the future.
The whole kernel is using identifiers starting with a double underscore
left and right. The risk should be acceptable though - also because the
kernel isn't linked against external libraries.
The sole reason why _current_thread_info was a local variable is so nobody
else can use it - the proper interface to use is current_thread_info().
Other than that, both the current and the proposed variant aren't really
correct for a variable that really is per thread. So I'm going to just
queue this for 3.20.
Thanks!
Ralf
next prev parent reply other threads:[~2015-01-16 14:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 12:06 [PATCH] MIPS: Changed current_thread_info() to an equivalent supported by both clang and GCC Daniel Sanders
2015-01-09 12:06 ` Daniel Sanders
2015-01-09 12:17 ` Sergei Shtylyov
2015-01-09 13:23 ` Daniel Sanders
2015-01-09 17:26 ` David Daney
2015-01-09 20:06 ` Daniel Sanders
2015-01-09 23:29 ` Behan Webster
2015-01-09 23:52 ` David Daney
2015-01-10 12:53 ` Daniel Sanders
2015-01-16 14:37 ` Ralf Baechle [this message]
2015-01-16 15:05 ` Måns Rullgård
2015-01-16 15:05 ` Måns Rullgård
2015-01-17 16:16 ` Daniel Sanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116143725.GB22296@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Daniel.Sanders@imgtec.com \
--cc=James.Hogan@imgtec.com \
--cc=Markos.Chandras@imgtec.com \
--cc=Paul.Burton@imgtec.com \
--cc=behanw@converseincode.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox