From: Marcelo Tosatti <mtosatti@redhat.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Ralf Baechle <ralf@linux-mips.org>,
Gleb Natapov <gleb@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
linux-mips@linux-mips.org, kvm@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: KVM: Fix trace event to save PC directly
Date: Mon, 2 Mar 2015 19:15:36 -0300 [thread overview]
Message-ID: <20150302221536.GA4095@amt.cnet> (raw)
In-Reply-To: <1424778380-28036-1-git-send-email-james.hogan@imgtec.com>
On Tue, Feb 24, 2015 at 11:46:20AM +0000, James Hogan wrote:
> Currently the guest exit trace event saves the VCPU pointer to the
> structure, and the guest PC is retrieved by dereferencing it when the
> event is printed rather than directly from the trace record. This isn't
> safe as the printing may occur long afterwards, after the PC has changed
> and potentially after the VCPU has been freed. Usually this results in
> the same (wrong) PC being printed for multiple trace events. It also
> isn't portable as userland has no way to access the VCPU data structure
> when interpreting the trace record itself.
>
> Lets save the actual PC in the structure so that the correct value is
> accessible later.
Applied, thanks.
prev parent reply other threads:[~2015-03-02 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 11:46 [PATCH] MIPS: KVM: Fix trace event to save PC directly James Hogan
2015-02-24 11:46 ` James Hogan
2015-02-24 14:10 ` Steven Rostedt
2015-02-24 14:10 ` Steven Rostedt
2015-03-02 22:15 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302221536.GA4095@amt.cnet \
--to=mtosatti@redhat.com \
--cc=gleb@kernel.org \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox