From: Ralf Baechle <ralf@linux-mips.org>
To: Huacai Chen <chenhc@lemote.com>
Cc: "Steven J. Hill" <Steven.Hill@imgtec.com>,
linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>
Subject: Re: [PATCH V8 7/8] MIPS: Loongson-3: Add chipset ACPI platform driver
Date: Thu, 26 Mar 2015 13:36:55 +0100 [thread overview]
Message-ID: <20150326123654.GC9705@linux-mips.org> (raw)
In-Reply-To: <1426213706-28542-2-git-send-email-chenhc@lemote.com>
On Fri, Mar 13, 2015 at 10:28:26AM +0800, Huacai Chen wrote:
> This add south-bridge (SB700/SB710/SB800 chipset) ACPI platform driver
> for Loongson-3. This will be used by EC (Embedded Controller, used by
> laptops) driver and STR (Suspend To RAM).
No Kconfig options? In commit 6/8 the Kconfig help text promises:
+++ b/drivers/platform/mips/Kconfig
@@ -0,0 +1,26 @@
+#
+# MIPS Platform Specific Drivers
+#
+
+menuconfig MIPS_PLATFORM_DEVICES
+ bool "MIPS Platform Specific Device Drivers"
+ default y
+ help
+ Say Y here to get to see options for device drivers of various
+ MIPS platforms, including vendor-specific netbook/laptop/desktop
+ extension and hardware monitor drivers. This option itself does
+ not add any kernel code.
Then this patch adds loongson-specific code that will be built for all
MIPS platforms. And it will fail to build for non-loongson platforms.
Ralf
next prev parent reply other threads:[~2015-03-26 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 2:28 [PATCH V8 6/8] MIPS: Loongson-3: Add CPU Hwmon platform driver Huacai Chen
2015-03-13 2:28 ` [PATCH V8 7/8] MIPS: Loongson-3: Add chipset ACPI " Huacai Chen
2015-03-26 12:36 ` Ralf Baechle [this message]
2015-03-26 13:53 ` Huacai Chen
2015-03-26 12:32 ` [PATCH V8 6/8] MIPS: Loongson-3: Add CPU Hwmon " Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326123654.GC9705@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Steven.Hill@imgtec.com \
--cc=chenhc@lemote.com \
--cc=linux-mips@linux-mips.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox