From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 20 May 2015 03:01:49 +0200 (CEST) Received: from smtp.codeaurora.org ([198.145.29.96]:37971 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27013022AbbETBBrUmzWA (ORCPT ); Wed, 20 May 2015 03:01:47 +0200 Received: from smtp.codeaurora.org (localhost [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 3CBBF14058B; Wed, 20 May 2015 01:01:46 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 486) id 1D2A61405CE; Wed, 20 May 2015 01:01:46 +0000 (UTC) Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B43E814058B; Wed, 20 May 2015 01:01:45 +0000 (UTC) Date: Tue, 19 May 2015 18:01:44 -0700 From: Stephen Boyd To: Mikko Perttunen Cc: Boris Brezillon , Mike Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Corbet , Shawn Guo , ascha Hauer , David Brown , Daniel Walker , Bryan Huntsman , Tony Lindgren , Paul Walmsley , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Ralf Baechle , Max Filippov , Heiko Stuebner , Sylwester Nawrocki , Tomasz Figa , Barry Song , Viresh Kumar , Emilio L?pez , Maxime Ripard , Peter De Schrijver , Prashant Gaikwad , Stephen Warren , Thierry Reding , Alexandre Courbot , Tero Kristo , Ulf Hansson , Michal Simek , Philipp Zabel , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org, linux-mips@linux-mips.org, patches@opensource.wolfsonmicro.com, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, spear-devel@list.st.com, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype Message-ID: <20150520010144.GA31054@codeaurora.org> References: <1430407809-31147-1-git-send-email-boris.brezillon@free-electrons.com> <1430407809-31147-2-git-send-email-boris.brezillon@free-electrons.com> <20150507063953.GC32399@codeaurora.org> <20150507093702.0b58753d@bbrezillon> <20150515174048.4a31af49@bbrezillon> <5557267D.7080209@kapsi.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5557267D.7080209@kapsi.fi> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: ClamAV using ClamSMTP Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 47483 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: sboyd@codeaurora.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 05/16, Mikko Perttunen wrote: > On 05/15/2015 06:40 PM, Boris Brezillon wrote: > >Hi Stephen, > > > >Adding Mikko in the loop (after all, he was the one complaining about > >this signed long limitation in the first place, and I forgot to add > >him in the Cc list :-/). > > I think I got it through linux-tegra anyway, but thanks :) > > > > >Mikko, are you okay with the approach proposed by Stephen (adding a > >new method) ? > > Yes, sounds good to me. If a driver uses the existing methods with > too large frequencies, the issue is pretty discoverable anyway. I > think "adjust_rate" sounds a bit too much like it sets the clock's > rate, though; perhaps "adjust_rate_request" or something like that? > Well I'm also OK with changing the determine_rate API one more time, but we'll have to be careful. Invariably someone will push a new clock driver through some non-clk tree path and we'll get build breakage. They shouldn't be doing that, so either we do the change now and push it to -next and see what breaks, or we do this after -rc1 comes out and make sure everyone has lots of warning. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project