From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 28 Jul 2015 14:34:47 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:35555 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27011235AbbG1MepKaG6M (ORCPT ); Tue, 28 Jul 2015 14:34:45 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.15.1/8.14.8) with ESMTP id t6SCYhLO026970; Tue, 28 Jul 2015 14:34:43 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.15.1/8.15.1/Submit) id t6SCYgN7026969; Tue, 28 Jul 2015 14:34:42 +0200 Date: Tue, 28 Jul 2015 14:34:42 +0200 From: Ralf Baechle To: Stefan Tatschner Cc: ludwig.kuerzinger@aisec.fraunhofer.de, Markos Chandras , stable@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH 6/9] MIPS: fpu.h: Allow 64-bit FPU on a 64-bit MIPS R6 CPU Message-ID: <20150728123442.GC24049@linux-mips.org> References: <1437999987-24879-1-git-send-email-stefan@sevenbyte.org> <1437999987-24879-6-git-send-email-stefan@sevenbyte.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437999987-24879-6-git-send-email-stefan@sevenbyte.org> User-Agent: Mutt/1.5.23 (2014-03-12) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 48486 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Stefan, On Mon, Jul 27, 2015 at 02:26:24PM +0200, Stefan Tatschner wrote: > Date: Mon, 27 Jul 2015 14:26:24 +0200 > From: Stefan Tatschner > To: ludwig.kuerzinger@aisec.fraunhofer.de > Cc: Markos Chandras , stable@vger.kernel.org, > linux-mips@linux-mips.org, Ralf Baechle > Subject: [PATCH 6/9] MIPS: fpu.h: Allow 64-bit FPU on a 64-bit MIPS R6 CPU > Content-Type: multipart/mixed; boundary="------------2.4.6" > > > Commit 6134d94923d0 ("MIPS: asm: fpu: Allow 64-bit FPU on MIPS32 R6") > added support for 64-bit FPU on a 32-bit MIPS R6 processor but it missed > the 64-bit CPU case leading to FPU failures when requesting FR=1 mode > (which is always the case for MIPS R6 userland) when running a 32-bit > kernel on a 64-bit CPU. We also fix the MIPS R2 case. > > Signed-off-by: Markos Chandras > Fixes: 6134d94923d0 ("MIPS: asm: fpu: Allow 64-bit FPU on MIPS32 R6") > Reviewed-by: Paul Burton > Cc: # 4.0+ > Cc: linux-mips@linux-mips.org > Patchwork: https://patchwork.linux-mips.org/patch/10734/ > Signed-off-by: Ralf Baechle > --- > arch/mips/include/asm/fpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/include/asm/fpu.h b/arch/mips/include/asm/fpu.h > index 084780b..1b06251 100644 > --- a/arch/mips/include/asm/fpu.h > +++ b/arch/mips/include/asm/fpu.h > @@ -74,7 +74,7 @@ static inline int __enable_fpu(enum fpu_mode mode) > goto fr_common; > > case FPU_64BIT: > -#if !(defined(CONFIG_CPU_MIPS32_R2) || defined(CONFIG_CPU_MIPS32_R6) \ > +#if !(defined(CONFIG_CPU_MIPSR2) || defined(CONFIG_CPU_MIPSR6) \ > || defined(CONFIG_64BIT)) > /* we only have a 32-bit FPU */ > return SIGFPE; You seem to be reflecting patch back to the linux-mips mailing list and other folks mentioned in patches, including myself. Please stop that. Ralf