From: Alban <albeu@free.fr>
To: Alexander Couzens <lynxis@fe80.eu>
Cc: Aban Bedel <albeu@free.fr>,
linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] MIPS: ath79: set irq ACK handler for ar7100-misc-intc irq chip
Date: Mon, 10 Aug 2015 20:11:14 +0200 [thread overview]
Message-ID: <20150810201114.468748de@tock> (raw)
In-Reply-To: <1438857805-18443-1-git-send-email-lynxis@fe80.eu>
On Thu, 6 Aug 2015 12:43:24 +0200
Alexander Couzens <lynxis@fe80.eu> wrote:
A log message would be nice. IMHO it should mention that the ACK
callbacks have been missed when introducing OF support.
> Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
> ---
> arch/mips/ath79/irq.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/ath79/irq.c b/arch/mips/ath79/irq.c
> index afb0096..dc76fa1 100644
> --- a/arch/mips/ath79/irq.c
> +++ b/arch/mips/ath79/irq.c
> @@ -303,13 +303,20 @@ static int __init ath79_misc_intc_of_init(
> __raw_writel(0, base + AR71XX_RESET_REG_MISC_INT_ENABLE);
> __raw_writel(0, base + AR71XX_RESET_REG_MISC_INT_STATUS);
>
> -
I would prefer to see this in another patch.
[...]
Alban
prev parent reply other threads:[~2015-08-10 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 10:43 [PATCH 1/2] MIPS: ath79: set irq ACK handler for ar7100-misc-intc irq chip Alexander Couzens
2015-08-06 10:43 ` [PATCH 2/2] MIPS: ath79: add irq chip ar7240-misc-intc Alexander Couzens
2015-08-10 18:22 ` Alban
2015-08-10 18:11 ` Alban [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150810201114.468748de@tock \
--to=albeu@free.fr \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-mips@linux-mips.org \
--cc=lynxis@fe80.eu \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox