From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 26 Aug 2015 20:37:12 +0200 (CEST) Received: from smtp.codeaurora.org ([198.145.29.96]:56524 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27012942AbbHZSglMIbIz (ORCPT ); Wed, 26 Aug 2015 20:36:41 +0200 Received: from smtp.codeaurora.org (localhost [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 6A628141321; Wed, 26 Aug 2015 18:36:40 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 486) id 4E467141320; Wed, 26 Aug 2015 18:36:40 +0000 (UTC) Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5265F14131B; Wed, 26 Aug 2015 18:36:39 +0000 (UTC) Date: Wed, 26 Aug 2015 11:36:38 -0700 From: Stephen Boyd To: Govindraj Raja Cc: linux-mips@linux-mips.org, linux-clk@vger.kernel.org, Michael Turquette , Zdenko Pulitika , Kevin Cernekee , Ralf Baechle , Andrew Bresticker , James Hartley , Damien Horsley , James Hogan , Ezequiel Garcia , Sergei Shtylyov , stable@vger.kernel.org Subject: Re: [PATCH v6 3/4] clk: pistachio: Fix PLL rate calculation in integer mode Message-ID: <20150826183638.GQ19120@codeaurora.org> References: <1440605500-13274-1-git-send-email-Govindraj.Raja@imgtec.com> <1440605500-13274-4-git-send-email-Govindraj.Raja@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440605500-13274-4-git-send-email-Govindraj.Raja@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: ClamAV using ClamSMTP Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 49034 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: sboyd@codeaurora.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 08/26, Govindraj Raja wrote: > From: Zdenko Pulitika > > .recalc_rate callback for the fractional PLL doesn't take operating > mode into account when calculating PLL rate. This results in > the incorrect PLL rates when PLL is operating in integer mode. > > Operating mode of fractional PLL is based on the value of the > fractional divider. Currently it assumes that the PLL will always > be configured in fractional mode which may not be > the case. This may result in the wrong output frequency. > > Also vco was calculated based on the current operating mode which > makes no sense because .set_rate is setting operating mode. Instead, > vco should be calculated using PLL settings that are about to be set. > > Fixes: 43049b0c83f17("CLK: Pistachio: Add PLL driver") > Cc: # 4.1 > Reviewed-by: Andrew Bresticker > Signed-off-by: Zdenko Pulitika > Signed-off-by: Govindraj Raja > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project