From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sun, 10 Jan 2016 12:42:47 +0100 (CET) Received: from mx1.redhat.com ([209.132.183.28]:50417 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27007671AbcAJLmn6vI3S (ORCPT ); Sun, 10 Jan 2016 12:42:43 +0100 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 18B378DFFA; Sun, 10 Jan 2016 11:42:40 +0000 (UTC) Received: from redhat.com (vpn1-5-155.ams2.redhat.com [10.36.5.155]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0ABgTaC032702; Sun, 10 Jan 2016 06:42:29 -0500 Date: Sun, 10 Jan 2016 13:42:28 +0200 From: "Michael S. Tsirkin" To: Joe Perches Cc: linux-kernel@vger.kernel.org, "Cc : Andy Whitcroft" , Peter Zijlstra , Arnd Bergmann , linux-arch@vger.kernel.org, Andrew Cooper , virtualization@lists.linux-foundation.org, Stefano Stabellini , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , David Miller , linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net, adi-buildroot-devel@lists.sourceforge.net, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, xen-devel@lists.xenproject.org, Ingo Molnar , Tony Lindgren , Andrey Konovalov , Russell King - ARM Linux Subject: Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers Message-ID: <20160110134133-mutt-send-email-mst@redhat.com> References: <1451907395-15978-1-git-send-email-mst@redhat.com> <1451907395-15978-2-git-send-email-mst@redhat.com> <1451923660.4334.83.camel@perches.com> <20160104224415-mutt-send-email-mst@redhat.com> <1451945750.4334.111.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1451945750.4334.111.camel@perches.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 50992 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: mst@redhat.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Mon, Jan 04, 2016 at 02:15:50PM -0800, Joe Perches wrote: > On Mon, 2016-01-04 at 22:45 +0200, Michael S. Tsirkin wrote: > > On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote: > > > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote: > > > > SMP-only barriers were missing in checkpatch.pl > > > > > > > > Refactor code slightly to make adding more variants easier. > > > > > > > > Signed-off-by: Michael S. Tsirkin > > > > --- > > > >  scripts/checkpatch.pl | 9 ++++++++- > > > >  1 file changed, 8 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > > > index 2b3c228..0245bbe 100755 > > > > --- a/scripts/checkpatch.pl > > > > +++ b/scripts/checkpatch.pl > > > > @@ -5116,7 +5116,14 @@ sub process { > > > >   } > > > >   } > > > >  # check for memory barriers without a comment. > > > > - if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) { > > > > + > > > > + my @barriers = ('mb', 'rmb', 'wmb', 'read_barrier_depends'); > > > > + my @smp_barriers = ('smp_store_release', 'smp_load_acquire', 'smp_store_mb'); > > > > + > > > > + @smp_barriers = (@smp_barriers, map {"smp_" . $_} @barriers); > > > > > > I think using map, which so far checkpatch doesn't use, > > > makes smp_barriers harder to understand and it'd be > > > better to enumerate them. > > > > Okay - I'll rewrite using foreach. > > > > I think using the qr form (like 'our $Attribute' and > a bunch of others) is the general style that should > be used for checkpatch. Thanks - that's what I did in the new version (included in v3 of the arch cleanup patchset now).