From: Aurelien Jarno <aurelien@aurel32.net>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH 0/7] MIPS: math-emu: Branch delay slot emulation fixes
Date: Sat, 23 Jan 2016 13:39:32 +0100 [thread overview]
Message-ID: <20160123123932.GA522@aurel32.net> (raw)
In-Reply-To: <alpine.DEB.2.00.1601220227590.5958@tp.orcam.me.uk>
Hi,
On 2016-01-22 05:20, Maciej W. Rozycki wrote:
> Hi,
>
> This small patch series addresses the following issues with branch delay
> slot emulation in our floating-point emulator:
>
> - NOP emulation sometimes causes SIGILL (Aurelien's bug),
>
> - microMIPS emulation always goes astray,
>
> - microMIPS emulation of ADDIUPC always returns the wrong result.
>
> Also included are a bunch of code clean-ups and comment fixes. See
> individual patch descriptions for further details.
>
> I attempted to move clean-ups to the end, so that they do not interfere
> with backporting, except with 2/7 which, if reordered, would require 3/7
> to become ill-formatted. I hope this is OK. Changes 5-7/7 do not require
> backporting.
>
> This series has been validated with a MIPS M5150 processor.
Thanks for working on that. I have tested this series, and I confirm
this fixes the issue and works well, though I haven't tested them on
a system with microMIPS support.
So for all the patches:
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
And for patch 1:
Tested-by: Aurelien Jarno <aurelien@aurel32.net>
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2016-01-23 12:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 5:20 [PATCH 0/7] MIPS: math-emu: Branch delay slot emulation fixes Maciej W. Rozycki
2016-01-22 5:20 ` Maciej W. Rozycki
2016-01-22 5:20 ` [PATCH 1/7] MIPS: math-emu: Correctly handle NOP emulation Maciej W. Rozycki
2016-01-22 5:20 ` Maciej W. Rozycki
2016-01-22 5:20 ` [PATCH 2/7] MIPS: math-emu: dsemul: Fix ill formatting of microMIPS part Maciej W. Rozycki
2016-01-22 5:20 ` Maciej W. Rozycki
2016-01-22 5:20 ` [PATCH 3/7] MIPS: math-emu: Make microMIPS branch delay slot emulation work Maciej W. Rozycki
2016-01-22 5:20 ` Maciej W. Rozycki
2016-01-22 5:21 ` [PATCH 4/7] MIPS: math-emu: Correct the emulation of microMIPS ADDIUPC instruction Maciej W. Rozycki
2016-01-22 5:21 ` Maciej W. Rozycki
2016-01-22 5:21 ` [PATCH 5/7] MIPS: math-emu: dsemul: Correct description of the emulation frame Maciej W. Rozycki
2016-01-22 5:21 ` Maciej W. Rozycki
2016-01-22 5:21 ` [PATCH 6/7] MIPS: inst.h: Fix some instruction descriptions Maciej W. Rozycki
2016-01-22 5:21 ` Maciej W. Rozycki
2016-01-22 5:21 ` [PATCH 7/7] MIPS: math-emu: dsemul: Reduce `get_isa16_mode' clutter Maciej W. Rozycki
2016-01-22 5:21 ` Maciej W. Rozycki
2016-01-23 12:39 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160123123932.GA522@aurel32.net \
--to=aurelien@aurel32.net \
--cc=linux-mips@linux-mips.org \
--cc=macro@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox