From: Ralf Baechle <ralf@linux-mips.org>
To: Manuel Lauss <manuel.lauss@gmail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
Chen Gang <gang.chen.5i5j@gmail.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH] MIPS: fix double definition of MADV_FREE
Date: Sun, 24 Jan 2016 01:21:18 +0100 [thread overview]
Message-ID: <20160124002118.GA25940@linux-mips.org> (raw)
In-Reply-To: <1453541623-710122-1-git-send-email-manuel.lauss@gmail.com>
On Sat, Jan 23, 2016 at 10:33:43AM +0100, Manuel Lauss wrote:
> Commit ef58978f1eaab140081ec1808d96ee06e933e760
> ("mm: define MADV_FREE for some arches") introduced MADV_FREE to MIPS,
> commit 21f55b018ba57897f4d3590ecbe11516bdc540af
> ("arch/*/include/uapi/asm/mman.h: : let MADV_FREE have same value for all architectures")
> added another instance, which resulted in this build error:
>
> In file included from include/uapi/linux/mman.h:4:0,
> from include/linux/mman.h:8,
> from kernel/fork.c:28:
> arch/mips/include/uapi/asm/mman.h:79:0: warning: "MADV_FREE" redefined
> #define MADV_FREE 8 /* free pages only if memory pressure */
> ^
> arch/mips/include/uapi/asm/mman.h:76:0: note: this is the location of the previous definition
> #define MADV_FREE 5 /* free pages only if memory pressure */
>
>
> This patch removes the "MADV_FREE 5" introduced by the first commit
> ("mm: define MADV_FREE for some arches").
Guenter Roeck's commit dcd6c87cc59af1b4fe7664b35c6344bbe1c9928f
("mm: arch: remove duplicate definitions of MADV_FREE") already fixed the
issue.
Thanks,
Ralf
prev parent reply other threads:[~2016-01-24 0:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 9:33 [PATCH] MIPS: fix double definition of MADV_FREE Manuel Lauss
2016-01-24 0:21 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160124002118.GA25940@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@gmail.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox