From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 03 Feb 2016 11:33:07 +0100 (CET) Received: from mailapp01.imgtec.com ([195.59.15.196]:18182 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010839AbcBCKdFYKL2O (ORCPT ); Wed, 3 Feb 2016 11:33:05 +0100 Received: from hhmail02.hh.imgtec.org (unknown [10.100.10.20]) by Websense Email Security Gateway with ESMTPS id 814D5C743BBF4; Wed, 3 Feb 2016 10:32:54 +0000 (GMT) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by hhmail02.hh.imgtec.org (10.100.10.20) with Microsoft SMTP Server (TLS) id 14.3.266.1; Wed, 3 Feb 2016 10:32:56 +0000 Received: from localhost (10.100.200.105) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Wed, 3 Feb 2016 10:32:55 +0000 Date: Wed, 3 Feb 2016 10:32:55 +0000 From: Paul Burton To: Sergei Shtylyov CC: , Ralf Baechle , "Andrey Konovalov" , Andrey Ryabinin , , Andrew Morton Subject: Re: [PATCH 4/5] MIPS: Support R_MIPS_PC16 rel-style reloc Message-ID: <20160203103255.GA21157@NP-P-BURTON> References: <1454471085-20963-1-git-send-email-paul.burton@imgtec.com> <1454471085-20963-5-git-send-email-paul.burton@imgtec.com> <56B1D5B5.6050208@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <56B1D5B5.6050208@cogentembedded.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [10.100.200.105] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 51657 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: paul.burton@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Wed, Feb 03, 2016 at 01:25:57PM +0300, Sergei Shtylyov wrote: > Hello. > > On 2/3/2016 6:44 AM, Paul Burton wrote: > >MIPS32 code uses rel-style relocs, and MIPS32r6 modules may include the > >R_MIPS_PC16 relocation. We thus need to support R_MIPS_PC16 rel-style > >relocations in order to load MIPS32r6 kernel modules. This patch adds > >such support, which is similar to the rela-style R_MIPS_PC16 support but > > R_MIPS_LO16, you mean? Hi Sergei, No, I mean it's similar to the R_MIPS_PC16 code in module-rela.c. That is, its rela-style equivalent (rather than rel-style as here). Thanks, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:18182 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010839AbcBCKdFYKL2O (ORCPT ); Wed, 3 Feb 2016 11:33:05 +0100 Date: Wed, 3 Feb 2016 10:32:55 +0000 From: Paul Burton Subject: Re: [PATCH 4/5] MIPS: Support R_MIPS_PC16 rel-style reloc Message-ID: <20160203103255.GA21157@NP-P-BURTON> References: <1454471085-20963-1-git-send-email-paul.burton@imgtec.com> <1454471085-20963-5-git-send-email-paul.burton@imgtec.com> <56B1D5B5.6050208@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <56B1D5B5.6050208@cogentembedded.com> Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Sergei Shtylyov Cc: linux-mips@linux-mips.org, Ralf Baechle , Andrey Konovalov , Andrey Ryabinin , linux-kernel@vger.kernel.org, Andrew Morton Message-ID: <20160203103255.S5GHgPy3p9siLNGfwJq3jvxYmxNkGtZkIpq00pr_He0@z> On Wed, Feb 03, 2016 at 01:25:57PM +0300, Sergei Shtylyov wrote: > Hello. > > On 2/3/2016 6:44 AM, Paul Burton wrote: > >MIPS32 code uses rel-style relocs, and MIPS32r6 modules may include the > >R_MIPS_PC16 relocation. We thus need to support R_MIPS_PC16 rel-style > >relocations in order to load MIPS32r6 kernel modules. This patch adds > >such support, which is similar to the rela-style R_MIPS_PC16 support but > > R_MIPS_LO16, you mean? Hi Sergei, No, I mean it's similar to the R_MIPS_PC16 code in module-rela.c. That is, its rela-style equivalent (rather than rel-style as here). Thanks, Paul