From: Paul Burton <paul.burton@imgtec.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org,
"Steven J. Hill" <Steven.Hill@imgtec.com>,
"Joshua Kinard" <kumba@gentoo.org>,
linux-kernel@vger.kernel.org, "Rafał Miłecki" <zajec5@gmail.com>,
"James Hogan" <james.hogan@imgtec.com>,
"Markos Chandras" <markos.chandras@imgtec.com>
Subject: Re: [PATCH] MIPS: tlb-r4k: panic if the MMU doesn't support PAGE_SIZE
Date: Wed, 10 Feb 2016 14:10:49 -0800 [thread overview]
Message-ID: <20160210221049.GA26712@NP-P-BURTON> (raw)
In-Reply-To: <1436803964-29820-1-git-send-email-paul.burton@imgtec.com>
On Mon, Jul 13, 2015 at 05:12:44PM +0100, Paul Burton wrote:
> After writing the appropriate mask to the cop0 PageMask register, read
> the register back & check it matches what we want. If it doesn't then
> the MMU does not support the page size the kernel is configured for and
> we're better off bailing than continuing to do odd things with TLB
> exceptions.
>
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> ---
Hi Ralf,
This patch is marked as accepted in patchwork[1] but is not present in
upstream. Did you lose it somehow? Could you please merge it?
Thanks,
Paul
[1] http://patchwork.linux-mips.org/patch/10691/
> arch/mips/mm/tlb-r4k.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/mips/mm/tlb-r4k.c b/arch/mips/mm/tlb-r4k.c
> index 08318ec..4330315 100644
> --- a/arch/mips/mm/tlb-r4k.c
> +++ b/arch/mips/mm/tlb-r4k.c
> @@ -19,6 +19,7 @@
> #include <asm/cpu.h>
> #include <asm/cpu-type.h>
> #include <asm/bootinfo.h>
> +#include <asm/hazards.h>
> #include <asm/mmu_context.h>
> #include <asm/pgtable.h>
> #include <asm/tlb.h>
> @@ -486,6 +487,10 @@ static void r4k_tlb_configure(void)
> * be set to fixed-size pages.
> */
> write_c0_pagemask(PM_DEFAULT_MASK);
> + back_to_back_c0_hazard();
> + if (read_c0_pagemask() != PM_DEFAULT_MASK)
> + panic("MMU doesn't support PAGE_SIZE=0x%lx", PAGE_SIZE);
> +
> write_c0_wired(0);
> if (current_cpu_type() == CPU_R10000 ||
> current_cpu_type() == CPU_R12000 ||
> --
> 2.4.5
>
next prev parent reply other threads:[~2016-02-10 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 16:12 [PATCH] MIPS: tlb-r4k: panic if the MMU doesn't support PAGE_SIZE Paul Burton
2015-07-13 16:12 ` Paul Burton
2016-02-10 22:10 ` Paul Burton [this message]
2016-02-11 19:37 ` Maciej W. Rozycki
2016-02-12 10:57 ` Ralf Baechle
2016-02-12 16:34 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210221049.GA26712@NP-P-BURTON \
--to=paul.burton@imgtec.com \
--cc=Steven.Hill@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=kumba@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox