From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 15 Apr 2016 23:19:53 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:45983 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27026713AbcDOVTtkASMb (ORCPT ); Fri, 15 Apr 2016 23:19:49 +0200 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Websense Email with ESMTPS id 2CA62F509E4F2; Fri, 15 Apr 2016 22:19:39 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (TLS) id 14.3.266.1; Fri, 15 Apr 2016 22:19:43 +0100 Received: from localhost (10.100.200.59) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.266.1; Fri, 15 Apr 2016 22:19:42 +0100 Date: Fri, 15 Apr 2016 22:19:42 +0100 From: Paul Burton To: James Hogan , Ralf Baechle CC: , "Maciej W. Rozycki" , , Jonas Gorski , "Markos Chandras" , Alex Smith , "Kirill A. Shutemov" , Andrew Morton Subject: Re: [PATCH 03/12] MIPS: Remove redundant asm/pgtable-bits.h inclusions Message-ID: <20160415211942.GA21163@NP-P-BURTON> References: <1460716620-13382-1-git-send-email-paul.burton@imgtec.com> <1460716620-13382-4-git-send-email-paul.burton@imgtec.com> <20160415191640.GE7859@jhogan-linux.le.imgtec.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20160415191640.GE7859@jhogan-linux.le.imgtec.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [10.100.200.59] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 53014 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: paul.burton@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Fri, Apr 15, 2016 at 08:16:40PM +0100, James Hogan wrote: > On Fri, Apr 15, 2016 at 11:36:51AM +0100, Paul Burton wrote: > > asm/pgtable-bits.h is included in 2 assembly files and thus has to > > in either of the assembly files that include it. > > That could do with rewording :-) Oops, it appears that I accidentally some words. Originally there was an extra line in the middle so that it read something like: asm/pgtable-bits.h is included in 2 assembly files and thus has to #ifdef around C code, however nothing defined by the header is used in either of the assembly files that include it. Ralf: Would you be ok with adding back that line to the commit message if this gets merged without needing a v2? > Otherwise > Reviewed-by: James Hogan Thanks James :) Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:45983 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27026713AbcDOVTtkASMb (ORCPT ); Fri, 15 Apr 2016 23:19:49 +0200 Date: Fri, 15 Apr 2016 22:19:42 +0100 From: Paul Burton Subject: Re: [PATCH 03/12] MIPS: Remove redundant asm/pgtable-bits.h inclusions Message-ID: <20160415211942.GA21163@NP-P-BURTON> References: <1460716620-13382-1-git-send-email-paul.burton@imgtec.com> <1460716620-13382-4-git-send-email-paul.burton@imgtec.com> <20160415191640.GE7859@jhogan-linux.le.imgtec.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20160415191640.GE7859@jhogan-linux.le.imgtec.org> Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: James Hogan , Ralf Baechle Cc: linux-mips@linux-mips.org, "Maciej W. Rozycki" , linux-kernel@vger.kernel.org, Jonas Gorski , Markos Chandras , Alex Smith , "Kirill A. Shutemov" , Andrew Morton Message-ID: <20160415211942.0Rbl3ZMCCzGQSy82Zu6NB2VcrUOh2zj1N1Qu9zl01LI@z> On Fri, Apr 15, 2016 at 08:16:40PM +0100, James Hogan wrote: > On Fri, Apr 15, 2016 at 11:36:51AM +0100, Paul Burton wrote: > > asm/pgtable-bits.h is included in 2 assembly files and thus has to > > in either of the assembly files that include it. > > That could do with rewording :-) Oops, it appears that I accidentally some words. Originally there was an extra line in the middle so that it read something like: asm/pgtable-bits.h is included in 2 assembly files and thus has to #ifdef around C code, however nothing defined by the header is used in either of the assembly files that include it. Ralf: Would you be ok with adding back that line to the commit message if this gets merged without needing a v2? > Otherwise > Reviewed-by: James Hogan Thanks James :) Paul