From: Ralf Baechle <ralf@linux-mips.org>
To: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Implement __arch_bitrev* using bitswap for MIPSr6
Date: Mon, 9 May 2016 16:19:30 +0200 [thread overview]
Message-ID: <20160509141930.GB28818@linux-mips.org> (raw)
In-Reply-To: <1462538103-6633-1-git-send-email-paul.burton@imgtec.com>
On Fri, May 06, 2016 at 01:35:03PM +0100, Paul Burton wrote:
> Release 6 of the MIPS architecture introduced the bitswap instruction,
> which reverses the bits within each byte of a word. Make use of this
> instruction to implement the __arch_bitrev* functions, which should be
> faster for most MIPSr6 CPUs, reduces code size slightly and allows us to
> avoid the lookup table used by the generic implementation, saving 256
> bytes in the kernel binary by dropping that.
>
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Applied after fixing up a trivial conflict. It would be a bit cleaner
if <asm/bitrev.h> was including <linux/types.h> itself. <linux/swab.h>
does so but there's no guarantee for that.
Ralf
prev parent reply other threads:[~2016-05-09 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 12:35 [PATCH] MIPS: Implement __arch_bitrev* using bitswap for MIPSr6 Paul Burton
2016-05-06 12:35 ` Paul Burton
2016-05-09 14:19 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509141930.GB28818@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox