From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 10 May 2016 10:09:44 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:59134 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27028568AbcEJIJlpArOv (ORCPT ); Tue, 10 May 2016 10:09:41 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.15.2/8.14.8) with ESMTP id u4A89ehf018040; Tue, 10 May 2016 10:09:40 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.15.2/8.15.2/Submit) id u4A89eda018039; Tue, 10 May 2016 10:09:40 +0200 Date: Tue, 10 May 2016 10:09:40 +0200 From: Ralf Baechle To: Paul Burton Cc: linux-mips@linux-mips.org, "Maciej W. Rozycki" , linux-kernel@vger.kernel.org, James Hogan , Markos Chandras Subject: Re: [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation Message-ID: <20160510080940.GD16402@linux-mips.org> References: <1461243895-30371-1-git-send-email-paul.burton@imgtec.com> <1461243895-30371-2-git-send-email-paul.burton@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461243895-30371-2-git-send-email-paul.burton@imgtec.com> User-Agent: Mutt/1.6.0 (2016-04-01) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 53336 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Thu, Apr 21, 2016 at 02:04:45PM +0100, Paul Burton wrote: > The conditions for branching when emulating the BC1EQZ & BC1NEZ > instructions were backwards, leading to each of those instructions being > treated as the other. Fix this by reversing the conditions, and clear up > the code a little for readability & checkpatch. > > Fixes: c909ca718e8f ("MIPS: math-emu: Emulate missing BC1{EQ,NE}Z instructions") > Signed-off-by: Paul Burton > Reviewed-by: James Hogan Patch ok - but you may want to take Markos off the cc list. Or iff he's still interested, is there any new address for him to use instead? Ralf