Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Andy Isaacson <adi@hexapodia.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-mips@linux-mips.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Jayachandran C <jchandra@broadcom.com>,
	Ganesan Ramalingam <ganesanr@broadcom.com>,
	David Daney <david.daney@cavium.com>,
	linux-pci@vger.kernel.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH] PCI: PCI_PROBE_ONLY clean-up
Date: Fri, 24 Jun 2016 11:46:02 -0700	[thread overview]
Message-ID: <20160624184602.GG32461@hexapodia.org> (raw)
In-Reply-To: <20160624155021.GD5930@linux-mips.org>

On Fri, Jun 24, 2016 at 05:50:21PM +0200, Ralf Baechle wrote:
> >   bcm1480
> >     Andrew Isaacson <adi@broadcom.com>
> >     dc41f94f7709 ("Support for the BCM1480 on-chip PCI-X bridge.")
> > 
> >   ip27
> >     Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> >     96173a6c4ebc ("[MIPS] IP27: misc fixes")
> 
> Afair  I did originally implement the IP27 use of PCI_PROBE_ONLY.  The
> problem is that it was not possible for the kernel to assign resources
> properly on an IP27.  Also that would invalidate firmware configuration
> information, so we had to live with whatever the firmware (mis)configured
> for us.  Afair - it's a darn long time ...  I think the reasoning for
> the BCM1480 was similar but Andy will hopefully recall the details.

I don't remember the details, unfortunately, but my general recollection
is similar -- CFE on bcm1480 was doing a fairly good job of configuring
PCI, and I think we needed to preserve the configuration for Reasons
rather than letting the kernel change things away from the CFE setup.

I unfortunately no longer have any 1480 hardware to test on, nor do I
know who's left at BCM who might be able to validate this change.

-andy

  reply	other threads:[~2016-06-24 18:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23 22:16 [PATCH] PCI: PCI_PROBE_ONLY clean-up Bjorn Helgaas
2016-06-23 22:16 ` [PATCH] MIPS/PCI: Claim bus resources on PCI_PROBE_ONLY set-ups Bjorn Helgaas
2016-10-17  4:36   ` Joshua Kinard
2016-10-17 18:09     ` Lorenzo Pieralisi
2016-10-18  0:30       ` Joshua Kinard
2016-10-19 11:04         ` Lorenzo Pieralisi
2016-10-31 19:36           ` Joshua Kinard
2016-11-01  4:06             ` Lorenzo Pieralisi
2016-06-24 15:50 ` [PATCH] PCI: PCI_PROBE_ONLY clean-up Ralf Baechle
2016-06-24 18:46   ` Andy Isaacson [this message]
2016-06-24 22:35     ` Ralf Baechle
2016-06-24 23:24   ` Joshua Kinard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160624184602.GG32461@hexapodia.org \
    --to=adi@hexapodia.org \
    --cc=bhelgaas@google.com \
    --cc=david.daney@cavium.com \
    --cc=ganesanr@broadcom.com \
    --cc=jchandra@broadcom.com \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=ralf@linux-mips.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox