From: Dan Carpenter <dan.carpenter@oracle.com>
To: wuzhangjin@gmail.com
Cc: linux-mips@linux-mips.org
Subject: [bug report] MIPS: Lemote 2F: Add basic CS5536 VSM support
Date: Fri, 15 Jul 2016 23:03:59 +0300 [thread overview]
Message-ID: <20160715200359.GA31809@mwanda> (raw)
Hello Wu Zhangjin,
The patch 22c21003a91b: "MIPS: Lemote 2F: Add basic CS5536 VSM
support" from Nov 10, 2009, leads to the following static checker
warning:
arch/mips/loongson64/common/cs5536/cs5536_ohci.c:141 pci_ohci_read_reg()
warn: masked condition '(lo & 3840) == 11' is always false.
arch/mips/loongson64/common/cs5536/cs5536_ohci.c
135 case PCI_INTERRUPT_LINE:
136 conf_data =
137 CFG_PCI_INTERRUPT_LINE(PCI_DEFAULT_PIN, CS5536_USB_INTR);
138 break;
139 case PCI_OHCI_INT_REG:
140 _rdmsr(DIVIL_MSR_REG(PIC_YSEL_LOW), &hi, &lo);
141 if ((lo & 0x00000f00) == CS5536_USB_INTR)
^^^^^^^^^^^^^^^
This is 11 so the condition can't be true. I don't know what was
intended.
142 conf_data = 1;
143 break;
144 default:
145 break;
146 }
regards,
dan carpenter
next reply other threads:[~2016-07-15 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 20:03 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-24 19:10 [bug report] MIPS: Lemote 2F: Add basic CS5536 VSM support Dan Carpenter
2017-08-24 22:04 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715200359.GA31809@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-mips@linux-mips.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox