From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 15 Aug 2016 22:33:12 +0200 (CEST) Received: from mail5.windriver.com ([192.103.53.11]:33306 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992579AbcHOUbw030QS (ORCPT ); Mon, 15 Aug 2016 22:31:52 +0200 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id u7FKVMc9030454 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK); Mon, 15 Aug 2016 13:31:22 -0700 Received: from yow-lpgnfs-02.wrs.com (128.224.149.8) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.248.2; Mon, 15 Aug 2016 13:31:21 -0700 From: Paul Gortmaker To: CC: Paul Gortmaker , Hauke Mehrtens , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Ralf Baechle , Aurelien Jarno Subject: [PATCH 1/4] mips: bcm47xx: make serial explicitly non-modular Date: Mon, 15 Aug 2016 16:30:52 -0400 Message-ID: <20160815203055.20541-2-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.8.4 In-Reply-To: <20160815203055.20541-1-paul.gortmaker@windriver.com> References: <20160815203055.20541-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 54557 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: paul.gortmaker@windriver.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips The Makefile entry controlling compilation of this code is "obj-y" meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modular infrastructure use, so that when reading the driver there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. We also delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments. Cc: Hauke Mehrtens Cc: "Rafał Miłecki" Cc: Ralf Baechle Cc: Aurelien Jarno Cc: linux-mips@linux-mips.org Signed-off-by: Paul Gortmaker --- arch/mips/bcm47xx/serial.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/arch/mips/bcm47xx/serial.c b/arch/mips/bcm47xx/serial.c index df761d38f7fc..e3c9872a4aa5 100644 --- a/arch/mips/bcm47xx/serial.c +++ b/arch/mips/bcm47xx/serial.c @@ -1,4 +1,7 @@ /* + * 8250 UART probe driver for the BCM47XX platforms + * Author: Aurelien Jarno + * * This file is subject to the terms and conditions of the GNU General Public * License. See the file "COPYING" in the main directory of this archive * for more details. @@ -6,7 +9,6 @@ * Copyright (C) 2007 Aurelien Jarno */ -#include #include #include #include @@ -88,9 +90,4 @@ static int __init uart8250_init(void) } return -EINVAL; } - -module_init(uart8250_init); - -MODULE_AUTHOR("Aurelien Jarno "); -MODULE_LICENSE("GPL"); -MODULE_DESCRIPTION("8250 UART probe driver for the BCM47XX platforms"); +device_initcall(uart8250_init); -- 2.8.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail5.windriver.com ([192.103.53.11]:33306 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992579AbcHOUbw030QS (ORCPT ); Mon, 15 Aug 2016 22:31:52 +0200 From: Paul Gortmaker Subject: [PATCH 1/4] mips: bcm47xx: make serial explicitly non-modular Date: Mon, 15 Aug 2016 16:30:52 -0400 Message-ID: <20160815203055.20541-2-paul.gortmaker@windriver.com> In-Reply-To: <20160815203055.20541-1-paul.gortmaker@windriver.com> References: <20160815203055.20541-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: linux-mips@linux-mips.org Cc: Paul Gortmaker , Hauke Mehrtens , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Ralf Baechle , Aurelien Jarno Message-ID: <20160815203052.Xd6ACvCKVwx5CpvzF95ziaVhQ-yabjc5ha61tREksko@z> The Makefile entry controlling compilation of this code is "obj-y" meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modular infrastructure use, so that when reading the driver there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. We also delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments. Cc: Hauke Mehrtens Cc: "Rafał Miłecki" Cc: Ralf Baechle Cc: Aurelien Jarno Cc: linux-mips@linux-mips.org Signed-off-by: Paul Gortmaker --- arch/mips/bcm47xx/serial.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/arch/mips/bcm47xx/serial.c b/arch/mips/bcm47xx/serial.c index df761d38f7fc..e3c9872a4aa5 100644 --- a/arch/mips/bcm47xx/serial.c +++ b/arch/mips/bcm47xx/serial.c @@ -1,4 +1,7 @@ /* + * 8250 UART probe driver for the BCM47XX platforms + * Author: Aurelien Jarno + * * This file is subject to the terms and conditions of the GNU General Public * License. See the file "COPYING" in the main directory of this archive * for more details. @@ -6,7 +9,6 @@ * Copyright (C) 2007 Aurelien Jarno */ -#include #include #include #include @@ -88,9 +90,4 @@ static int __init uart8250_init(void) } return -EINVAL; } - -module_init(uart8250_init); - -MODULE_AUTHOR("Aurelien Jarno "); -MODULE_LICENSE("GPL"); -MODULE_DESCRIPTION("8250 UART probe driver for the BCM47XX platforms"); +device_initcall(uart8250_init); -- 2.8.4